From b011e827cf8af31cc38b28c9a5d9f90ad8fbfab2 Mon Sep 17 00:00:00 2001
From: Sergey Biryukov <sergeybiryukov@git.wordpress.org>
Date: Tue, 26 Sep 2023 00:23:25 +0000
Subject: [PATCH] Code Modernization: Rename parameters that use reserved
 keywords in `phpunit/tests/media.php`.

While using reserved PHP keywords as parameter name labels is allowed, in the context of function calls using named parameters in PHP 8.0+, this will easily lead to confusion. To avoid that, it is recommended not to use reserved keywords as function parameter names.

This commit renames the `$match` parameter to `$matches` in shortcode image tests.

Note: This is enforced by WPCS 3.0.0.

Follow-up to [56693].

See #58831.

git-svn-id: https://develop.svn.wordpress.org/trunk@56694 602fd350-edb4-49c9-b593-d223f7449a82
---
 tests/phpunit/tests/media.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/phpunit/tests/media.php b/tests/phpunit/tests/media.php
index 87b25e8b3d..3b8615dd82 100644
--- a/tests/phpunit/tests/media.php
+++ b/tests/phpunit/tests/media.php
@@ -5162,8 +5162,8 @@ EOF;
 				array( '', '<img fetchpriority="high" ' ),
 				preg_replace_callback(
 					'/gallery-(\d+)/',
-					static function ( $match ) {
-						return 'gallery-' . ( (int) $match[1] + 1 );
+					static function ( $matches ) {
+						return 'gallery-' . ( (int) $matches[1] + 1 );
 					},
 					do_shortcode( '[gallery ids="' . self::$large_id . '" size="large" id="' . $post_id . '"]' )
 				)