From b0d1b8b43301931c7b9622a05750620c1625901c Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Thu, 7 Aug 2014 20:08:18 +0000 Subject: [PATCH] Create a new Backbone view, `media.view.Label`, which can be used as a subview in things like toolbars, which need screen reader text. Make an initial instance of it for the label for Bulk Actions in Media Grid. See #29026. git-svn-id: https://develop.svn.wordpress.org/trunk@29434 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/js/media-grid.js | 10 +++++++++- src/wp-includes/js/media-views.js | 19 +++++++++++++++++++ src/wp-includes/media.php | 1 + 3 files changed, 29 insertions(+), 1 deletion(-) diff --git a/src/wp-includes/js/media-grid.js b/src/wp-includes/js/media-grid.js index 9491e8d6cb..8f243c182c 100644 --- a/src/wp-includes/js/media-grid.js +++ b/src/wp-includes/js/media-grid.js @@ -540,6 +540,13 @@ }); + this.views.add( new media.view.Label({ + value: l10n.bulkActionsLabel, + attributes: { + 'for': 'bulk-select-dropdown' + } + }) ); + this.views.add( new media.view.BulkSelectionActionDropdown({ controller: this @@ -565,7 +572,8 @@ * @augments Backbone.View */ media.view.BulkSelectionActionDropdown = media.View.extend({ - tagName: 'select', + tagName: 'select', + id: 'bulk-select-dropdown', initialize: function() { media.view.Button.prototype.initialize.apply( this, arguments ); diff --git a/src/wp-includes/js/media-views.js b/src/wp-includes/js/media-views.js index 7b767c609f..409a4991da 100644 --- a/src/wp-includes/js/media-views.js +++ b/src/wp-includes/js/media-views.js @@ -6567,6 +6567,25 @@ } }); + /** + * @constructor + * @augments wp.media.View + * @augments wp.Backbone.View + * @augments Backbone.View + */ + media.view.Label = media.View.extend({ + tagName: 'label', + className: 'screen-reader-text', + + initialize: function() { + this.value = this.options.value; + }, + + render: function() { + this.$el.html( this.value ); + } + }); + /** * wp.media.view.EmbedUrl * diff --git a/src/wp-includes/media.php b/src/wp-includes/media.php index 4391e610ec..5eea90c6fe 100644 --- a/src/wp-includes/media.php +++ b/src/wp-includes/media.php @@ -2937,6 +2937,7 @@ function wp_enqueue_media( $args = array() ) { 'warnDelete' => __( "You are about to permanently delete this item.\n 'Cancel' to stop, 'OK' to delete." ), 'warnBulkDelete' => __( "You are about to permanently delete these items.\n 'Cancel' to stop, 'OK' to delete." ), 'bulkActions' => __( 'Bulk Actions' ), + 'bulkActionsLabel' => __( 'Select bulk action' ), 'deletePermanently' => __( 'Delete Permanently' ), 'apply' => __( 'Apply' ),