From b13ab6b4a3308a5d5d39125f61108d3ef6efac46 Mon Sep 17 00:00:00 2001 From: Adam Silverstein Date: Thu, 15 Jun 2017 09:37:53 +0000 Subject: [PATCH] Media: Disable the edit image->replace button when no item selected. On the edit media screen, ensure that the 'replace' button is disabled until a media item is selected. Fix an issue where clicking the button with no item selected threw a JavaScript error and failed to work. Props timmydcrawford, subrataemfluence, psiico. Fixes #40589. git-svn-id: https://develop.svn.wordpress.org/trunk@40902 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/js/media-views.js | 1 + src/wp-includes/js/media/views/frame/image-details.js | 1 + 2 files changed, 2 insertions(+) diff --git a/src/wp-includes/js/media-views.js b/src/wp-includes/js/media-views.js index 46f6e30122..7ea9ed3cb6 100644 --- a/src/wp-includes/js/media-views.js +++ b/src/wp-includes/js/media-views.js @@ -5116,6 +5116,7 @@ ImageDetails = Select.extend({ style: 'primary', text: l10n.replace, priority: 80, + requires: { selection: true }, click: function() { var controller = this.controller, diff --git a/src/wp-includes/js/media/views/frame/image-details.js b/src/wp-includes/js/media/views/frame/image-details.js index a75c8ae64e..ed38174903 100644 --- a/src/wp-includes/js/media/views/frame/image-details.js +++ b/src/wp-includes/js/media/views/frame/image-details.js @@ -146,6 +146,7 @@ ImageDetails = Select.extend({ style: 'primary', text: l10n.replace, priority: 80, + requires: { selection: true }, click: function() { var controller = this.controller,