From b18d047edd83fc572c0b2af23b273c76d8d75b1f Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Thu, 12 Sep 2013 05:56:59 +0000 Subject: [PATCH] * Avoid `Only variables should be passed by reference` notice by passing a var to `array_pop()` in `tests/user.php` * Suppress a notice by silencing the passing of a non-existent object prop See #25282. git-svn-id: https://develop.svn.wordpress.org/trunk@25390 602fd350-edb4-49c9-b593-d223f7449a82 --- tests/phpunit/tests/user.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/phpunit/tests/user.php b/tests/phpunit/tests/user.php index 6ead4590e2..8e8cdf086e 100644 --- a/tests/phpunit/tests/user.php +++ b/tests/phpunit/tests/user.php @@ -130,7 +130,8 @@ class Tests_User extends WP_UnitTestCase { $this->assertTrue(isset($out[$k]) && $out[$k][0] == $v); // delete one key and check again - $key_to_delete = array_pop(array_keys($vals)); + $keys = array_keys( $vals ); + $key_to_delete = array_pop( $keys ); delete_user_meta($user_id, $key_to_delete); $out = get_user_meta($user_id); // make sure that key is excluded from the results @@ -572,7 +573,7 @@ class Tests_User extends WP_UnitTestCase { $user = WP_User::get_data_by( 'id', false ); $this->assertEquals( false, $user ); - $user = WP_User::get_data_by( 'id', $user->user_nicename ); + $user = WP_User::get_data_by( 'id', @$user->user_nicename ); $this->assertEquals( false, $user ); $user = WP_User::get_data_by( 'id', 99999 );