vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-10-06 07:36:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Code Modernization: Remove dynamic properties in Tests_*_Slashes.

Browse Source 
Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.

In this particular case, the test classes contain a `set_up()` method that sets a group of properties, which are ''used'' by the tests, but the values of these properties are never ''changed'' by the tests.

In other words, setting these properties in the `set_up()` is an unnecessary overhead and the properties should be changed to class constants.

Follow-up to [1041/tests], [1071/tests].

Props jrf.
See #56033.

git-svn-id: https://develop.svn.wordpress.org/trunk@53557 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2022-06-23 14:24:08 +00:00
parent 2c11931a4a
commit bafecbeab5
7 changed files with 379 additions and 352 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/term/slashes.php
+38 -32
View File
@@ -6,6 +6,20 @@
* @ticket 21767
*/
class Tests_Term_Slashes extends WP_Ajax_UnitTestCase {
/*
* It is important to test with both even and odd numbered slashes,
* as KSES does a strip-then-add slashes in some of its function calls.
*/
const SLASH_1 = 'String with 1 slash \\';
const SLASH_2 = 'String with 2 slashes \\\\';
const SLASH_3 = 'String with 3 slashes \\\\\\';
const SLASH_4 = 'String with 4 slashes \\\\\\\\';
const SLASH_5 = 'String with 5 slashes \\\\\\\\\\';
const SLASH_6 = 'String with 6 slashes \\\\\\\\\\\\';
const SLASH_7 = 'String with 7 slashes \\\\\\\\\\\\\\';
protected static $author_id;
public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
@@ -16,14 +30,6 @@ class Tests_Term_Slashes extends WP_Ajax_UnitTestCase {
parent::set_up();
wp_set_current_user( self::$author_id );
$this->slash_1 = 'String with 1 slash \\';
$this->slash_2 = 'String with 2 slashes \\\\';
$this->slash_3 = 'String with 3 slashes \\\\\\';
$this->slash_4 = 'String with 4 slashes \\\\\\\\';
$this->slash_5 = 'String with 5 slashes \\\\\\\\\\';
$this->slash_6 = 'String with 6 slashes \\\\\\\\\\\\';
$this->slash_7 = 'String with 7 slashes \\\\\\\\\\\\\\';
}
/**
@@ -36,40 +42,40 @@ class Tests_Term_Slashes extends WP_Ajax_UnitTestCase {
);
foreach ( $taxonomies as $taxonomy ) {
$insert = wp_insert_term(
$this->slash_1,
self::SLASH_1,
$taxonomy,
array(
'slug' => 'slash_test_1_' . $taxonomy,
'description' => $this->slash_3,
'description' => self::SLASH_3,
)
);
$term = get_term( $insert['term_id'], $taxonomy );
$this->assertSame( wp_unslash( $this->slash_1 ), $term->name );
$this->assertSame( wp_unslash( $this->slash_3 ), $term->description );
$this->assertSame( wp_unslash( self::SLASH_1 ), $term->name );
$this->assertSame( wp_unslash( self::SLASH_3 ), $term->description );
$insert = wp_insert_term(
$this->slash_3,
self::SLASH_3,
$taxonomy,
array(
'slug' => 'slash_test_2_' . $taxonomy,
'description' => $this->slash_5,
'description' => self::SLASH_5,
)
);
$term = get_term( $insert['term_id'], $taxonomy );
$this->assertSame( wp_unslash( $this->slash_3 ), $term->name );
$this->assertSame( wp_unslash( $this->slash_5 ), $term->description );
$this->assertSame( wp_unslash( self::SLASH_3 ), $term->name );
$this->assertSame( wp_unslash( self::SLASH_5 ), $term->description );
$insert = wp_insert_term(
$this->slash_2,
self::SLASH_2,
$taxonomy,
array(
'slug' => 'slash_test_3_' . $taxonomy,
'description' => $this->slash_4,
'description' => self::SLASH_4,
)
);
$term = get_term( $insert['term_id'], $taxonomy );
$this->assertSame( wp_unslash( $this->slash_2 ), $term->name );
$this->assertSame( wp_unslash( $this->slash_4 ), $term->description );
$this->assertSame( wp_unslash( self::SLASH_2 ), $term->name );
$this->assertSame( wp_unslash( self::SLASH_4 ), $term->description );
}
}
@@ -92,38 +98,38 @@ class Tests_Term_Slashes extends WP_Ajax_UnitTestCase {
$term_id,
$taxonomy,
array(
'name' => $this->slash_1,
'description' => $this->slash_3,
'name' => self::SLASH_1,
'description' => self::SLASH_3,
)
);
$term = get_term( $term_id, $taxonomy );
$this->assertSame( wp_unslash( $this->slash_1 ), $term->name );
$this->assertSame( wp_unslash( $this->slash_3 ), $term->description );
$this->assertSame( wp_unslash( self::SLASH_1 ), $term->name );
$this->assertSame( wp_unslash( self::SLASH_3 ), $term->description );
$update = wp_update_term(
$term_id,
$taxonomy,
array(
'name' => $this->slash_3,
'description' => $this->slash_5,
'name' => self::SLASH_3,
'description' => self::SLASH_5,
)
);
$term = get_term( $term_id, $taxonomy );
$this->assertSame( wp_unslash( $this->slash_3 ), $term->name );
$this->assertSame( wp_unslash( $this->slash_5 ), $term->description );
$this->assertSame( wp_unslash( self::SLASH_3 ), $term->name );
$this->assertSame( wp_unslash( self::SLASH_5 ), $term->description );
$update = wp_update_term(
$term_id,
$taxonomy,
array(
'name' => $this->slash_2,
'description' => $this->slash_4,
'name' => self::SLASH_2,
'description' => self::SLASH_4,
)
);
$term = get_term( $term_id, $taxonomy );
$this->assertSame( wp_unslash( $this->slash_2 ), $term->name );
$this->assertSame( wp_unslash( $this->slash_4 ), $term->description );
$this->assertSame( wp_unslash( self::SLASH_2 ), $term->name );
$this->assertSame( wp_unslash( self::SLASH_4 ), $term->description );
}
}
}