vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-08-11 12:20:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Canonical URLs: Redirect to the correct URL when the post date changes.

Browse Source 
When a post slug is changed, we store a copy of the old slug, so that we can redirect visitors visiting the old URL to the new URL.

In the same way, this stores a copy of the old date, when the post date changes, so we can redirect visitors to the new URL.

Props nickmomrik.
Fixes #15397 for trunk.



git-svn-id: https://develop.svn.wordpress.org/trunk@42401 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Gary Pendergast
2017-12-15 08:30:50 +00:00
parent 95ccede93d
commit c07972d774
4 changed files with 349 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/rewrite/oldDateRedirect.php
+217
View File
@@ -0,0 +1,217 @@
<?php
/**
* @group rewrite
*/
class Tests_Rewrite_OldDateRedirect extends WP_UnitTestCase {
protected $old_date_redirect_url;
protected $post_id;
public function setUp() {
parent::setUp();
$this->post_id = self::factory()->post->create( array(
'post_title' => 'Foo Bar',
'post_name' => 'foo-bar',
) );
add_filter( 'old_slug_redirect_url', array( $this, 'filter_old_date_redirect_url' ), 10, 1 );
$this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
add_rewrite_endpoint( 'custom-endpoint', EP_PERMALINK );
add_rewrite_endpoint( 'second-endpoint', EP_PERMALINK, 'custom' );
flush_rewrite_rules();
}
public function tearDown() {
parent::tearDown();
$this->old_date_redirect_url = null;
remove_filter( 'old_slug_redirect_url', array( $this, 'filter_old_date_redirect_url' ), 10 );
}
public function test_old_date_redirect() {
$old_permalink = user_trailingslashit( get_permalink( $this->post_id ) );
$time = '2004-01-03 00:00:00';
wp_update_post( array(
'ID' => $this->post_id,
'post_date' => $time,
'post_date_gmt' => get_gmt_from_date( $time ),
) );
$permalink = user_trailingslashit( get_permalink( $this->post_id ) );
$this->go_to( $old_permalink );
wp_old_slug_redirect();
$this->assertEquals( $permalink, $this->old_date_redirect_url );
}
public function test_old_date_slug_redirect() {
$old_permalink = user_trailingslashit( get_permalink( $this->post_id ) );
$time = '2004-01-03 00:00:00';
wp_update_post( array(
'ID' => $this->post_id,
'post_date' => $time,
'post_date_gmt' => get_gmt_from_date( $time ),
'post_name' => 'bar-baz',
) );
$permalink = user_trailingslashit( get_permalink( $this->post_id ) );
$this->go_to( $old_permalink );
wp_old_slug_redirect();
$this->assertEquals( $permalink, $this->old_date_redirect_url );
}
public function test_old_date_redirect_attachment() {
$file = DIR_TESTDATA . '/images/canola.jpg';
$attachment_id = self::factory()->attachment->create_object( $file, $this->post_id, array(
'post_mime_type' => 'image/jpeg',
'post_name' => 'my-attachment',
) );
$old_permalink = get_attachment_link( $attachment_id );
$time = '2004-01-03 00:00:00';
wp_update_post( array(
'ID' => $this->post_id,
'post_date' => $time,
'post_date_gmt' => get_gmt_from_date( $time ),
) );
$this->go_to( $old_permalink );
wp_old_slug_redirect();
$this->assertNull( $this->old_date_redirect_url );
$this->assertQueryTrue( 'is_attachment', 'is_singular', 'is_single' );
$old_permalink = get_attachment_link( $attachment_id );
wp_update_post( array(
'ID' => $attachment_id,
'post_name' => 'the-attachment',
) );
$permalink = user_trailingslashit( trailingslashit( get_permalink( $this->post_id ) ) . 'the-attachment' );
$this->go_to( $old_permalink );
wp_old_slug_redirect();
$this->assertEquals( $permalink, $this->old_date_redirect_url );
}
public function test_old_date_slug_redirect_attachment() {
$file = DIR_TESTDATA . '/images/canola.jpg';
$attachment_id = self::factory()->attachment->create_object( $file, $this->post_id, array(
'post_mime_type' => 'image/jpeg',
'post_name' => 'my-attachment',
) );
$old_permalink = get_attachment_link( $attachment_id );
$time = '2004-01-03 00:00:00';
wp_update_post( array(
'ID' => $this->post_id,
'post_date' => $time,
'post_date_gmt' => get_gmt_from_date( $time ),
'post_name' => 'bar-baz',
) );
$this->go_to( $old_permalink );
wp_old_slug_redirect();
$this->assertNull( $this->old_date_redirect_url );
$this->assertQueryTrue( 'is_attachment', 'is_singular', 'is_single' );
$old_permalink = get_attachment_link( $attachment_id );
wp_update_post( array(
'ID' => $attachment_id,
'post_name' => 'the-attachment',
) );
$permalink = user_trailingslashit( trailingslashit( get_permalink( $this->post_id ) ) . 'the-attachment' );
$this->go_to( $old_permalink );
wp_old_slug_redirect();
$this->assertEquals( $permalink, $this->old_date_redirect_url );
}
public function test_old_date_redirect_paged() {
wp_update_post( array(
'ID' => $this->post_id,
'post_content' => 'Test<!--nextpage-->Test',
) );
$old_permalink = user_trailingslashit( trailingslashit( get_permalink( $this->post_id ) ) . 'page/2' );
$time = '2004-01-03 00:00:00';
wp_update_post( array(
'ID' => $this->post_id,
'post_date' => $time,
'post_date_gmt' => get_gmt_from_date( $time ),
) );
$permalink = user_trailingslashit( trailingslashit( get_permalink( $this->post_id ) ) . 'page/2' );
$this->go_to( $old_permalink );
wp_old_slug_redirect();
$this->assertEquals( $permalink, $this->old_date_redirect_url );
}
public function test_old_date_slug_redirect_paged() {
wp_update_post( array(
'ID' => $this->post_id,
'post_content' => 'Test<!--nextpage-->Test',
) );
$old_permalink = user_trailingslashit( trailingslashit( get_permalink( $this->post_id ) ) . 'page/2' );
$time = '2004-01-04 12:00:00';
wp_update_post( array(
'ID' => $this->post_id,
'post_date' => $time,
'post_date_gmt' => get_gmt_from_date( $time ),
'post_name' => 'bar-baz',
) );
$permalink = user_trailingslashit( trailingslashit( get_permalink( $this->post_id ) ) . 'page/2' );
$this->go_to( $old_permalink );
wp_old_slug_redirect();
$this->assertEquals( $permalink, $this->old_date_redirect_url );
}
public function test_old_date_slug_doesnt_redirect_when_reused() {
$old_permalink = user_trailingslashit( get_permalink( $this->post_id ) );
$time = '2004-01-04 12:00:00';
wp_update_post( array(
'ID' => $this->post_id,
'post_date' => $time,
'post_date_gmt' => get_gmt_from_date( $time ),
'post_name' => 'bar-baz',
) );
$new_post_id = self::factory()->post->create( array(
'post_title' => 'Foo Bar',
'post_name' => 'foo-bar',
) );
$permalink = user_trailingslashit( get_permalink( $new_post_id ) );
$this->assertEquals( $old_permalink, $permalink );
$this->go_to( $old_permalink );
wp_old_slug_redirect();
$this->assertNull( $this->old_date_redirect_url );
}
public function filter_old_date_redirect_url( $url ) {
$this->old_date_redirect_url = $url;
return false;
}
}