From c285dedee6505d3f18b3c763ca33795f2a2ed011 Mon Sep 17 00:00:00 2001
From: Aaron Jorbin
Date: Tue, 13 Feb 2024 14:17:29 +0000
Subject: [PATCH] Multisite: Escape urls and html elements in wp-activate.php
When WPMU was merged in [12603], the intent was to go back and make sure everything was escaped. This completes that intent.
Props rafiq91, rajinsharwar, costdev, oglekler, nicolefurlan, ryan, peterwilsoncc.
Fixes #57336.
See #11644.
git-svn-id: https://develop.svn.wordpress.org/trunk@57625 602fd350-edb4-49c9-b593-d223f7449a82
---
src/wp-activate.php | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/src/wp-activate.php b/src/wp-activate.php
index 36772a2d9d..5dc602337b 100644
--- a/src/wp-activate.php
+++ b/src/wp-activate.php
@@ -150,19 +150,19 @@ $blog_details = get_site();
printf(
/* translators: 1: Login URL, 2: Username, 3: User email address, 4: Lost password URL. */
__( 'Your account has been activated. You may now log in to the site using your chosen username of “%2$s”. Please check your email inbox at %3$s for your password and login instructions. If you do not receive an email, please check your junk or spam folder. If you still do not receive an email within an hour, you can reset your password.' ),
- network_site_url( $blog_details->path . 'wp-login.php', 'login' ),
- $signup->user_login,
- $signup->user_email,
- wp_lostpassword_url()
+ esc_url( network_site_url( $blog_details->path . 'wp-login.php', 'login' ) ),
+ esc_html( $signup->user_login ),
+ esc_html( $signup->user_email ),
+ esc_url( wp_lostpassword_url() )
);
} else {
printf(
/* translators: 1: Site URL, 2: Username, 3: User email address, 4: Lost password URL. */
__( 'Your site at %1$s is active. You may now log in to your site using your chosen username of “%2$s”. Please check your email inbox at %3$s for your password and login instructions. If you do not receive an email, please check your junk or spam folder. If you still do not receive an email within an hour, you can reset your password.' ),
- sprintf( '%1$s%2$s', $signup->domain, $blog_details->path ),
- $signup->user_login,
- $signup->user_email,
- wp_lostpassword_url()
+ sprintf( '%1$s', esc_url( $signup->domain . $blog_details->path ) ),
+ esc_html( $signup->user_login ),
+ esc_html( $signup->user_email ),
+ esc_url( wp_lostpassword_url() )
);
}
echo '
';
@@ -170,18 +170,18 @@ $blog_details = get_site();
?>
- get_error_message(); ?>
+ get_error_message() ); ?>
-
user_login; ?>
-
+
user_login ); ?>
+
View your site or Log in' ), $url, esc_url( $login_url ) );
+ printf( __( 'Your account is now activated. View your site or Log in' ), esc_url( $url ), esc_url( $login_url ) );
?>
@@ -202,8 +202,8 @@ $blog_details = get_site();
printf(
/* translators: 1: Login URL, 2: Network home URL. */
__( 'Your account is now activated. Log in or go back to the homepage.' ),
- network_site_url( $blog_details->path . 'wp-login.php', 'login' ),
- network_home_url( $blog_details->path )
+ esc_url( network_site_url( $blog_details->path . 'wp-login.php', 'login' ) ),
+ esc_url( network_home_url( $blog_details->path ) )
);
?>