vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-10-06 07:36:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Coding Standards: Fix the remaining issues in /tests.

Browse Source 
All PHP files in `/tests` now conform to the PHP coding standards, or have exceptions appropriately marked.

Travis now also runs `phpcs` on the `/tests` directory, any future changes to these files must conform entirely to the WordPress PHP coding standards. 🎉

See #47632.



git-svn-id: https://develop.svn.wordpress.org/trunk@45607 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Gary Pendergast
2019-07-08 00:55:20 +00:00
parent 431bc58a48
commit c6c78490e2
91 changed files with 435 additions and 320 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/dbdelta.php
+31 -16
View File
@@ -33,18 +33,22 @@ class Tests_dbDelta extends WP_UnitTestCase {
// Forcing MyISAM, because InnoDB only started supporting FULLTEXT indexes in MySQL 5.7.
$wpdb->query(
"
CREATE TABLE {$wpdb->prefix}dbdelta_test (
id bigint(20) NOT NULL AUTO_INCREMENT,
column_1 varchar(255) NOT NULL,
column_2 text,
column_3 blob,
PRIMARY KEY (id),
KEY key_1 (column_1($this->max_index_length)),
KEY compound_key (id,column_1($this->max_index_length)),
FULLTEXT KEY fulltext_key (column_1)
) ENGINE=MyISAM
"
$wpdb->prepare(
"
CREATE TABLE {$wpdb->prefix}dbdelta_test (
id bigint(20) NOT NULL AUTO_INCREMENT,
column_1 varchar(255) NOT NULL,
column_2 text,
column_3 blob,
PRIMARY KEY (id),
KEY key_1 (column_1(%d)),
KEY compound_key (id,column_1(%d)),
FULLTEXT KEY fulltext_key (column_1)
) ENGINE=MyISAM
",
$this->max_index_length,
$this->max_index_length
)
);
parent::setUp();
@@ -299,6 +303,7 @@ class Tests_dbDelta extends WP_UnitTestCase {
protected function assertTableRowHasValue( $column, $value, $table ) {
global $wpdb;
// phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
$table_row = $wpdb->get_row( "select $column from {$table} where $column = '$value'" );
$expected = (object) array(
@@ -317,7 +322,8 @@ class Tests_dbDelta extends WP_UnitTestCase {
protected function assertTableHasColumn( $column, $table ) {
global $wpdb;
$table_fields = $wpdb->get_results( "DESCRIBE {$table}" );
// phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
$table_fields = $wpdb->get_results( "DESCRIBE $table" );
$this->assertCount( 1, wp_list_filter( $table_fields, array( 'Field' => $column ) ) );
}
@@ -333,7 +339,8 @@ class Tests_dbDelta extends WP_UnitTestCase {
protected function assertTableHasPrimaryKey( $column, $table ) {
global $wpdb;
$table_indices = $wpdb->get_results( "SHOW INDEX FROM {$table}" );
// phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
$table_indices = $wpdb->get_results( "SHOW INDEX FROM $table" );
$this->assertCount(
1,
@@ -358,7 +365,8 @@ class Tests_dbDelta extends WP_UnitTestCase {
global $wpdb;
$table_fields = $wpdb->get_results( "DESCRIBE {$table}" );
// phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
$table_fields = $wpdb->get_results( "DESCRIBE $table" );
$this->assertCount( 0, wp_list_filter( $table_fields, array( 'Field' => $column ) ) );
}
@@ -385,15 +393,18 @@ class Tests_dbDelta extends WP_UnitTestCase {
KEY a_key (a)
) ENGINE=InnoDB ROW_FORMAT=DYNAMIC";
// phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
$wpdb->query( $create );
// phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
$index = $wpdb->get_row( "SHOW INDEXES FROM $table_name WHERE Key_name='a_key';" );
$actual = dbDelta( $create, false );
// phpcs:ignore WordPress.DB.PreparedSQL.InterpolatedNotPrepared
$wpdb->query( "DROP TABLE IF EXISTS $table_name;" );
if ( 191 != $index->Sub_part ) {
if ( 191 !== $index->Sub_part ) {
$this->markTestSkipped( 'This test requires the index to be truncated.' );
}
@@ -527,6 +538,7 @@ class Tests_dbDelta extends WP_UnitTestCase {
)
";
// phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
$wpdb->query( $schema );
$updates = dbDelta( $schema, false );
@@ -556,6 +568,7 @@ class Tests_dbDelta extends WP_UnitTestCase {
) ENGINE=MyISAM;
";
// phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
$wpdb->query( $schema );
$updates = dbDelta( $schema, false );
@@ -602,6 +615,7 @@ class Tests_dbDelta extends WP_UnitTestCase {
)
";
// phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
$wpdb->query( $schema );
$updates = dbDelta( $schema );
@@ -998,6 +1012,7 @@ class Tests_dbDelta extends WP_UnitTestCase {
)
";
// phpcs:ignore WordPress.DB.PreparedSQL.NotPrepared
$wpdb->query( $schema );
$schema_update = "