From c7320c5a86b78b496776885276e7dd523bbfdceb Mon Sep 17 00:00:00 2001 From: Boone Gorges Date: Fri, 30 Jan 2015 19:28:27 +0000 Subject: [PATCH] Fix 'quick_edit_show_taxonomy' filter so that can properly be used for overrides in all cases. See #26948. git-svn-id: https://develop.svn.wordpress.org/trunk@31308 602fd350-edb4-49c9-b593-d223f7449a82 --- .../includes/class-wp-posts-list-table.php | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/wp-admin/includes/class-wp-posts-list-table.php b/src/wp-admin/includes/class-wp-posts-list-table.php index 65c751bf06..960d59a9de 100644 --- a/src/wp-admin/includes/class-wp-posts-list-table.php +++ b/src/wp-admin/includes/class-wp-posts-list-table.php @@ -945,23 +945,20 @@ class WP_Posts_List_Table extends WP_List_Table { $flat_taxonomies = array(); foreach ( $taxonomy_names as $taxonomy_name ) { + $taxonomy = get_taxonomy( $taxonomy_name ); + + $show_in_quick_edit = $taxonomy->show_in_quick_edit; + /** * Filters whether the current taxonomy should be shown in the Quick Edit panel. * * @since 4.2.0 * - * @param bool $show Whether to show the current taxonomy in Quick Edit. - * Default: true. - * @param string $taxonomy_name Taxonomy name. - * @param string $post_type Post type of current Quick Edit post. + * @param bool $show_in_quick_edit Whether to show the current taxonomy in Quick Edit. + * @param string $taxonomy_name Taxonomy name. + * @param string $post_type Post type of current Quick Edit post. */ - if ( ! apply_filters( 'quick_edit_show_taxonomy', true, $taxonomy_name, $screen->post_type ) ) { - continue; - } - - $taxonomy = get_taxonomy( $taxonomy_name ); - - if ( ! $taxonomy->show_in_quick_edit ) { + if ( ! apply_filters( 'quick_edit_show_taxonomy', $show_in_quick_edit, $taxonomy_name, $screen->post_type ) ) { continue; }