From c8ab2675f4533f5704f0452cf671d3128df8a316 Mon Sep 17 00:00:00 2001 From: Andrew Nacin Date: Sat, 9 Nov 2013 21:28:27 +0000 Subject: [PATCH] Avoid JSHint errors in color-picker.js. One `var`, single quotes, add missing semicolon, declare wpColorPickerL10n as global. props jorbin. fixes #25877. git-svn-id: https://develop.svn.wordpress.org/trunk@26067 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/js/color-picker.js | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/wp-admin/js/color-picker.js b/src/wp-admin/js/color-picker.js index d564754787..7eb83446d4 100644 --- a/src/wp-admin/js/color-picker.js +++ b/src/wp-admin/js/color-picker.js @@ -1,13 +1,13 @@ +/* global wpColorPickerL10n:true */ ( function( $, undef ){ // html stuff var _before = '', _after = '
', _wrap = '
', - _button = ''; - + _button = '', // jQuery UI Widget constructor - var ColorPicker = { + ColorPicker = { options: { defaultColor: false, change: false, @@ -19,8 +19,8 @@ // bail early for unsupported Iris. if ( ! $.support.iris ) return; - var self = this; - var el = self.element; + var self = this, + el = self.element; $.extend( self.options, el.data() ); @@ -29,7 +29,7 @@ // Set up HTML structure, hide things el.addClass( 'wp-color-picker' ).hide().wrap( _wrap ); self.wrap = el.parent(); - self.toggler = $( _before ).insertBefore( el ).css( { backgroundColor: self.initialValue } ).attr( "title", wpColorPickerL10n.pick ).attr( "data-current", wpColorPickerL10n.current ); + self.toggler = $( _before ).insertBefore( el ).css( { backgroundColor: self.initialValue } ).attr( 'title', wpColorPickerL10n.pick ).attr( 'data-current', wpColorPickerL10n.current ); self.pickerContainer = $( _after ).insertAfter( el ); self.button = $( _button ); @@ -69,9 +69,9 @@ // close picker when you click outside it if ( self.toggler.hasClass( 'wp-picker-open' ) ) - $( "body" ).on( 'click', { wrap: self.wrap, toggler: self.toggler }, self._bodyListener ); + $( 'body' ).on( 'click', { wrap: self.wrap, toggler: self.toggler }, self._bodyListener ); else - $( "body" ).off( 'click', self._bodyListener ); + $( 'body' ).off( 'click', self._bodyListener ); }); self.element.change(function( event ) { @@ -114,9 +114,9 @@ // $("#input").wpColorPicker('color', '#bada55') to set color: function( newColor ) { if ( newColor === undef ) - return this.element.iris( "option", "color" ); + return this.element.iris( 'option', 'color' ); - this.element.iris( "option", "color", newColor ); + this.element.iris( 'option', 'color', newColor ); }, //$("#input").wpColorPicker('defaultColor') returns the current default color //$("#input").wpColorPicker('defaultColor', newDefaultColor) to set @@ -126,7 +126,7 @@ this.options.defaultColor = newDefaultColor; } - } + }; $.widget( 'wp.wpColorPicker', ColorPicker ); -}( jQuery ) ); \ No newline at end of file +}( jQuery ) );