vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-03-31 18:54:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Build/Test Tools: Begin eliminating unnecessary randomness in tests.

Browse Source 
Although unlikely, clashes in randomly generated strings could cause unexpected failures. In addition, most randomness is entirely unnecessary, is bad practice, and increases test time (however small it may be).

See #37371


git-svn-id: https://develop.svn.wordpress.org/trunk@38762 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
John Blackbourn
2016-10-09 01:11:14 +00:00
parent b45f2feada
commit c91be6f1fe
21 changed files with 105 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/phpunit/tests/file.php
View File

@@ -84,7 +84,7 @@ class Tests_File extends WP_UnitTestCase {
function test_unique_filename_is_valid() {
// make sure it produces a valid, writable, unique filename
$filename = wp_unique_filename( $this->dir, rand_str() . '.txt' );
$filename = wp_unique_filename( $this->dir, __FUNCTION__ . '.txt' );
$this->assertTrue( $this->is_unique_writable_file($this->dir, $filename) );
@@ -93,7 +93,7 @@ class Tests_File extends WP_UnitTestCase {
function test_unique_filename_is_unique() {
// make sure it produces two unique filenames
$name = rand_str();
$name = __FUNCTION__;
$filename1 = wp_unique_filename( $this->dir, $name . '.txt' );
$this->assertTrue( $this->is_unique_writable_file($this->dir, $filename1) );
@@ -108,7 +108,7 @@ class Tests_File extends WP_UnitTestCase {
}
function test_unique_filename_is_sanitized() {
$name = rand_str();
$name = __FUNCTION__;
$filename = wp_unique_filename( $this->dir, $name . $this->badchars . '.txt' );
// make sure the bad characters were all stripped out
@@ -120,7 +120,7 @@ class Tests_File extends WP_UnitTestCase {
}
function test_unique_filename_with_slashes() {
$name = rand_str();
$name = __FUNCTION__;
// "foo/foo.txt"
$filename = wp_unique_filename( $this->dir, $name . '/' . $name . '.txt' );
@@ -133,7 +133,7 @@ class Tests_File extends WP_UnitTestCase {
}
function test_unique_filename_multiple_ext() {
$name = rand_str();
$name = __FUNCTION__;
$filename = wp_unique_filename( $this->dir, $name . '.php.txt' );
// "foo.php.txt" becomes "foo.php_.txt"
@@ -145,7 +145,7 @@ class Tests_File extends WP_UnitTestCase {
}
function test_unique_filename_no_ext() {
$name = rand_str();
$name = __FUNCTION__;
$filename = wp_unique_filename( $this->dir, $name );
$this->assertEquals( $name, $filename );