vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-04-27 07:54:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Build/Test Tools: Begin eliminating unnecessary randomness in tests.

Browse Source 
Although unlikely, clashes in randomly generated strings could cause unexpected failures. In addition, most randomness is entirely unnecessary, is bad practice, and increases test time (however small it may be).

See #37371


git-svn-id: https://develop.svn.wordpress.org/trunk@38762 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
John Blackbourn
2016-10-09 01:11:14 +00:00
parent b45f2feada
commit c91be6f1fe
21 changed files with 105 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/phpunit/tests/multisite/site.php
View File

@@ -270,8 +270,8 @@ class Tests_Multisite_Site extends WP_UnitTestCase {
* should change with upload directories.
*/
function test_upload_directories_after_multiple_wpmu_delete_blog() {
$filename = rand_str().'.jpg';
$contents = rand_str();
$filename = __FUNCTION__ . '.jpg';
$contents = __FUNCTION__ . '_contents';
// Upload a file to the main site on the network.
$file1 = wp_upload_bits( $filename, null, $contents );