vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-04-11 08:04:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Use more appropriate assertions in various tests.

Browse Source 
This replaces instances of `assertTrue( in_array( ... ) )` with `assertContains()` to use native PHPUnit functionality.

Follow-up to [51335], [51337], [51367], [51397], [51403].

Props hellofromTonya, jrf, SergeyBiryukov.
Fixes #53123. See #53363.

git-svn-id: https://develop.svn.wordpress.org/trunk@51404 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2021-07-12 10:35:44 +00:00
parent 5d9a38ef41
commit c96a42e08a
25 changed files with 78 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/phpunit/tests/wp.php
View File

@@ -22,15 +22,15 @@ class Tests_WP extends WP_UnitTestCase {
$this->wp->add_query_var( 'test' );
$this->assertCount( $public_qv_count + 2, $this->wp->public_query_vars );
$this->assertTrue( in_array( 'test', $this->wp->public_query_vars, true ) );
$this->assertTrue( in_array( 'test2', $this->wp->public_query_vars, true ) );
$this->assertContains( 'test', $this->wp->public_query_vars );
$this->assertContains( 'test2', $this->wp->public_query_vars );
}
public function test_remove_query_var() {
$public_qv_count = count( $this->wp->public_query_vars );
$this->wp->add_query_var( 'test' );
$this->assertTrue( in_array( 'test', $this->wp->public_query_vars, true ) );
$this->assertContains( 'test', $this->wp->public_query_vars );
$this->wp->remove_query_var( 'test' );
$this->assertCount( $public_qv_count, $this->wp->public_query_vars );