From ca90afc1f8098f12752dcb3e4a8152dc92301daf Mon Sep 17 00:00:00 2001 From: Tonya Mork Date: Wed, 25 Jan 2023 21:54:43 +0000 Subject: [PATCH] Editor: Remove WP_DEBUG defined check in wp_tinycolor_hue_to_rgb(). The constant `WP_DEBUG` is a default constant that is set within `wp_initial_constants()` when not defined. This means the constant will always be defined, thus making the `defined( 'WP_DEBUG' )` unnecessary. Removing the `defined()` provides these benefits: * Makes the code more readable. * Tiny performance optimization. References: * https://github.com/WordPress/gutenberg/pull/45979 Follow-up to [52049]. Props ocean90, spacedmonkey, mamaduka. See #57527. git-svn-id: https://develop.svn.wordpress.org/trunk@55141 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/block-supports/duotone.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wp-includes/block-supports/duotone.php b/src/wp-includes/block-supports/duotone.php index 76542d8e37..d010fb893b 100644 --- a/src/wp-includes/block-supports/duotone.php +++ b/src/wp-includes/block-supports/duotone.php @@ -459,7 +459,7 @@ function wp_get_duotone_filter_svg( $preset ) { $svg = ob_get_clean(); - if ( ! defined( 'SCRIPT_DEBUG' ) || ! SCRIPT_DEBUG ) { + if ( ! SCRIPT_DEBUG ) { // Clean up the whitespace. $svg = preg_replace( "/[\r\n\t ]+/", ' ', $svg ); $svg = str_replace( '> <', '><', $svg ); @@ -543,7 +543,7 @@ function wp_render_duotone_support( $block_content, $block ) { // !important is needed because these styles render before global styles, // and they should be overriding the duotone filters set by global styles. - $filter_style = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG + $filter_style = SCRIPT_DEBUG ? $selector . " {\n\tfilter: " . $filter_property . " !important;\n}\n" : $selector . '{filter:' . $filter_property . ' !important;}';