vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-10-06 23:58:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Block Patterns: Update the value used for keywords.

Browse Source 
Patterns on the [https://wordpress.org/patterns/ Pattern Directory] can have keywords for better discoverability while searching. The way these are stored [https://github.com/WordPress/pattern-directory/commit/69548ff1f0326c4fd4d9ea7390c48b6d9d227055 was changed from a taxonomy to meta value], but the `/wp/v2/pattern-directory/patterns` endpoint was still pulling from that old value.

The correct property to use for this field is `meta.wpop_keywords`, which returns a single string with comma-separated keywords.

Props ryelle, TimothyBlynJacobs.
See #56126.

git-svn-id: https://develop.svn.wordpress.org/trunk@53665 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2022-07-05 16:01:36 +00:00
parent 8fa608877b
commit ccbdd73187
6 changed files with 17 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/data/blocks/pattern-directory/browse-all.json
+3
View File
@@ -9,6 +9,7 @@
"meta": {
"spay_email": "",
"wpop_description": "A heading preceded by a chapter number, and followed by a paragraph.",
"wpop_keywords": "blog post",
"wpop_viewport_width": 1000
},
"category_slugs": [ "text" ],
@@ -25,6 +26,7 @@
"meta": {
"spay_email": "",
"wpop_description": "A large hero section with an example background image and a heading in the center.",
"wpop_keywords": "header, hero",
"wpop_viewport_width": 1000
},
"category_slugs": [ "header" ],
@@ -41,6 +43,7 @@
"meta": {
"spay_email": "",
"wpop_description": "A large hero section with a bright gradient background, a big heading and a filled button.",
"wpop_keywords": "call to action, hero section",
"wpop_viewport_width": 1000
},
"category_slugs": [ "header" ],
tests/phpunit/data/blocks/pattern-directory/browse-category-2.json
+2
View File
@@ -9,6 +9,7 @@
"meta": {
"spay_email": "",
"wpop_description": "Three filled buttons with rounded corners, side by side.",
"wpop_keywords": "",
"wpop_viewport_width": 600
},
"category_slugs": [ "buttons" ],
@@ -25,6 +26,7 @@
"meta": {
"spay_email": "",
"wpop_description": "Two buttons, one filled and one outlined, side by side.",
"wpop_keywords": "",
"wpop_viewport_width": 500
},
"category_slugs": [ "buttons" ],
tests/phpunit/data/blocks/pattern-directory/browse-keyword-11.json
+3
View File
@@ -9,6 +9,7 @@
"meta": {
"spay_email": "",
"wpop_description": "A heading preceded by a chapter number, and followed by a paragraph.",
"wpop_keywords": "",
"wpop_viewport_width": 1000
},
"category_slugs": [ "text" ],
@@ -25,6 +26,7 @@
"meta": {
"spay_email": "",
"wpop_description": "A large hero section with an example background image and a heading in the center.",
"wpop_keywords": "",
"wpop_viewport_width": 1000
},
"category_slugs": [ "header" ],
@@ -41,6 +43,7 @@
"meta": {
"spay_email": "",
"wpop_description": "A large hero section with a bright gradient background, a big heading and a filled button.",
"wpop_keywords": "",
"wpop_viewport_width": 1000
},
"category_slugs": [ "header" ],
tests/phpunit/data/blocks/pattern-directory/search-button.json
+4
View File
@@ -9,6 +9,7 @@
"meta": {
"spay_email": "",
"wpop_description": "A large hero section with a bright gradient background, a big heading and a filled button.",
"wpop_keywords": "",
"wpop_viewport_width": 1000
},
"category_slugs": [ "header" ],
@@ -25,6 +26,7 @@
"meta": {
"spay_email": "",
"wpop_description": "Three small columns of text, each with an outlined button with rounded corners at the bottom.",
"wpop_keywords": "",
"wpop_viewport_width": 1000
},
"category_slugs": [ "columns" ],
@@ -41,6 +43,7 @@
"meta": {
"spay_email": "",
"wpop_description": "Three filled buttons with rounded corners, side by side.",
"wpop_keywords": "",
"wpop_viewport_width": 600
},
"category_slugs": [ "buttons" ],
@@ -57,6 +60,7 @@
"meta": {
"spay_email": "",
"wpop_description": "Two buttons, one filled and one outlined, side by side.",
"wpop_keywords": "",
"wpop_viewport_width": 500
},
"category_slugs": [ "buttons" ],
tests/phpunit/tests/rest-api/rest-pattern-directory-controller.php
+3 -4
View File
@@ -111,6 +111,9 @@ class WP_REST_Pattern_Directory_Controller_Test extends WP_Test_REST_Controller_
$this->assertGreaterThan( 0, count( $patterns ) );
array_walk( $patterns, array( $this, 'assertPatternMatchesSchema' ) );
$this->assertSame( array( 'blog post' ), $patterns[0]['keywords'] );
$this->assertSame( array( 'header', 'hero' ), $patterns[1]['keywords'] );
$this->assertSame( array( 'call to action', 'hero section' ), $patterns[2]['keywords'] );
}
/**
@@ -157,10 +160,6 @@ class WP_REST_Pattern_Directory_Controller_Test extends WP_Test_REST_Controller_
$this->assertGreaterThan( 0, count( $patterns ) );
array_walk( $patterns, array( $this, 'assertPatternMatchesSchema' ) );
foreach ( $patterns as $pattern ) {
$this->assertContains( 'core', $pattern['keywords'] );
}
}
/**