From cd188f40d1770ad68bb144d86c704248d164227c Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Thu, 25 Jun 2015 16:55:35 +0000 Subject: [PATCH] `WP_Rewrite::add_rule()` should strictly check against `false` when using `strpos()`. See #32444. git-svn-id: https://develop.svn.wordpress.org/trunk@32941 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/rewrite.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-includes/rewrite.php b/src/wp-includes/rewrite.php index ce3dbf21d6..cfa6bbec6d 100644 --- a/src/wp-includes/rewrite.php +++ b/src/wp-includes/rewrite.php @@ -2040,7 +2040,7 @@ class WP_Rewrite { */ public function add_rule($regex, $redirect, $after = 'bottom') { //get everything up to the first ? - $index = (strpos($redirect, '?') == false ? strlen($redirect) : strpos($redirect, '?')); + $index = (strpos($redirect, '?') === false ? strlen($redirect) : strpos($redirect, '?')); $front = substr($redirect, 0, $index); if ( $front != $this->index ) { //it doesn't redirect to WP's index.php $this->add_external_rule($regex, $redirect);