Add access modifiers to methods and members of list table classes:

* `WP_List_Table` is the base class that implements `__get()` and `__call()` for BC
* Adds unit tests to confirm that subclasses properly inherit magic methods
* Add modifiers to subclasses: `WP_Links_List_Table`, `WP_Media_List_Table`, `WP_MS_Sites_List_Table`, `WP_MS_Themes_List_Table`, `WP_MS_Users_List_Table`, `WP_Plugin_Install_List_Table`, `WP_Plugins_List_Table`, `WP_Posts_List_Table`, `WP_Terms_List_Table`, `WP_Theme_Install_List_Table`, `WP_Themes_List_Table`

See #27881, #22234.


git-svn-id: https://develop.svn.wordpress.org/trunk@28493 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2014-05-19 01:16:16 +00:00
parent 99c99b77e3
commit d6a3c2a0de
14 changed files with 239 additions and 188 deletions
@@ -9,7 +9,7 @@
*/
class WP_Plugins_List_Table extends WP_List_Table {
function __construct( $args = array() ) {
public function __construct( $args = array() ) {
global $status, $page;
parent::__construct( array(
@@ -27,15 +27,15 @@ class WP_Plugins_List_Table extends WP_List_Table {
$page = $this->get_pagenum();
}
function get_table_classes() {
protected function get_table_classes() {
return array( 'widefat', $this->_args['plural'] );
}
function ajax_user_can() {
public function ajax_user_can() {
return current_user_can('activate_plugins');
}
function prepare_items() {
public function prepare_items() {
global $status, $plugins, $totals, $page, $orderby, $order, $s;
wp_reset_vars( array( 'orderby', 'order', 's' ) );
@@ -172,7 +172,7 @@ class WP_Plugins_List_Table extends WP_List_Table {
) );
}
function _search_callback( $plugin ) {
public function _search_callback( $plugin ) {
static $term;
if ( is_null( $term ) )
$term = wp_unslash( $_REQUEST['s'] );
@@ -186,7 +186,7 @@ class WP_Plugins_List_Table extends WP_List_Table {
return false;
}
function _order_callback( $plugin_a, $plugin_b ) {
public function _order_callback( $plugin_a, $plugin_b ) {
global $orderby, $order;
$a = $plugin_a[$orderby];
@@ -201,7 +201,7 @@ class WP_Plugins_List_Table extends WP_List_Table {
return ( $a < $b ) ? -1 : 1;
}
function no_items() {
public function no_items() {
global $plugins;
if ( !empty( $plugins['all'] ) )
@@ -210,7 +210,7 @@ class WP_Plugins_List_Table extends WP_List_Table {
_e( 'You do not appear to have any plugins available at this time.' );
}
function get_columns() {
protected function get_columns() {
global $status;
return array(
@@ -220,11 +220,11 @@ class WP_Plugins_List_Table extends WP_List_Table {
);
}
function get_sortable_columns() {
protected function get_sortable_columns() {
return array();
}
function get_views() {
protected function get_views() {
global $totals, $status;
$status_links = array();
@@ -268,7 +268,7 @@ class WP_Plugins_List_Table extends WP_List_Table {
return $status_links;
}
function get_bulk_actions() {
protected function get_bulk_actions() {
global $status;
$actions = array();
@@ -289,7 +289,7 @@ class WP_Plugins_List_Table extends WP_List_Table {
return $actions;
}
function bulk_actions() {
public function bulk_actions() {
global $status;
if ( in_array( $status, array( 'mustuse', 'dropins' ) ) )
@@ -298,7 +298,7 @@ class WP_Plugins_List_Table extends WP_List_Table {
parent::bulk_actions();
}
function extra_tablenav( $which ) {
protected function extra_tablenav( $which ) {
global $status;
if ( ! in_array($status, array('recently_activated', 'mustuse', 'dropins') ) )
@@ -316,14 +316,14 @@ class WP_Plugins_List_Table extends WP_List_Table {
echo '</div>';
}
function current_action() {
public function current_action() {
if ( isset($_POST['clear-recent-list']) )
return 'clear-recent-list';
return parent::current_action();
}
function display_rows() {
protected function display_rows() {
global $status;
if ( is_multisite() && ! $this->screen->in_admin( 'network' ) && in_array( $status, array( 'mustuse', 'dropins' ) ) )
@@ -333,7 +333,7 @@ class WP_Plugins_List_Table extends WP_List_Table {
$this->single_row( array( $plugin_file, $plugin_data ) );
}
function single_row( $item ) {
protected function single_row( $item ) {
global $status, $page, $s, $totals;
list( $plugin_file, $plugin_data ) = $item;