From d9d04982549e348a6284184a65abbdc337f6105c Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Thu, 22 Jun 2023 05:53:05 +0000 Subject: [PATCH] Tests: Update the test for `pre_wp_setup_nav_menu_item` filter. This ensures that not only is the filter applied in `wp_setup_nav_menu_item()`, but also the actual output is tested. Follow-up to [55867], [55868]. Props azaozz, ugyensupport. Fixes #56577. git-svn-id: https://develop.svn.wordpress.org/trunk@55979 602fd350-edb4-49c9-b593-d223f7449a82 --- tests/phpunit/tests/post/nav-menu.php | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/phpunit/tests/post/nav-menu.php b/tests/phpunit/tests/post/nav-menu.php index 9d1cffe069..c0ae716ab8 100644 --- a/tests/phpunit/tests/post/nav-menu.php +++ b/tests/phpunit/tests/post/nav-menu.php @@ -608,12 +608,11 @@ class Tests_Post_Nav_Menu extends WP_UnitTestCase { ) ); - $filter = new MockAction(); - add_filter( 'pre_wp_setup_nav_menu_item', array( &$filter, 'filter' ) ); + add_filter( 'pre_wp_setup_nav_menu_item', '__return_empty_string' ); - wp_setup_nav_menu_item( get_post( $menu_item_id ) ); + $custom_item = wp_setup_nav_menu_item( get_post( $menu_item_id ) ); - $this->assertSame( 1, $filter->get_call_count() ); + $this->assertSame( '', $custom_item ); } /**