From da1f881cf4190b0c067f5b1359abaa778a018d5f Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Thu, 28 Dec 2023 15:25:26 +0000 Subject: [PATCH] External Libraries: Accessibility: Clean up `clipboard.js` Copy buttons from focus management workaround. `clipboard.js` used to suffer from a bug that triggered a focus loss when activating the Copy buttons. The bug was fixed a while ago with the `clipboard.js` 2.0.11 release so that the workaround implemented in WordPress is no longer necessary. Props dhrumilk, paulkevan, afercia. Fixes #60139. git-svn-id: https://develop.svn.wordpress.org/trunk@57231 602fd350-edb4-49c9-b593-d223f7449a82 --- src/js/_enqueues/admin/media.js | 2 -- src/js/_enqueues/admin/post.js | 2 -- src/js/_enqueues/admin/site-health.js | 2 -- src/js/_enqueues/vendor/plupload/handlers.js | 2 -- src/js/media/views/attachment/details.js | 2 -- 5 files changed, 10 deletions(-) diff --git a/src/js/_enqueues/admin/media.js b/src/js/_enqueues/admin/media.js index 648ade5828..ddc8a6c933 100644 --- a/src/js/_enqueues/admin/media.js +++ b/src/js/_enqueues/admin/media.js @@ -223,8 +223,6 @@ // Clear the selection and move focus back to the trigger. event.clearSelection(); - // Handle ClipboardJS focus bug, see https://github.com/zenorocha/clipboard.js/issues/680. - triggerElement.trigger( 'focus' ); // Show success visual feedback. clearTimeout( copyAttachmentURLSuccessTimeout ); diff --git a/src/js/_enqueues/admin/post.js b/src/js/_enqueues/admin/post.js index a86ea4c84b..eb577013d5 100644 --- a/src/js/_enqueues/admin/post.js +++ b/src/js/_enqueues/admin/post.js @@ -1303,8 +1303,6 @@ jQuery( function($) { // Clear the selection and move focus back to the trigger. event.clearSelection(); - // Handle ClipboardJS focus bug, see https://github.com/zenorocha/clipboard.js/issues/680 - triggerElement.trigger( 'focus' ); // Show success visual feedback. clearTimeout( copyAttachmentURLSuccessTimeout ); diff --git a/src/js/_enqueues/admin/site-health.js b/src/js/_enqueues/admin/site-health.js index 5b59771836..416295df69 100644 --- a/src/js/_enqueues/admin/site-health.js +++ b/src/js/_enqueues/admin/site-health.js @@ -26,8 +26,6 @@ jQuery( function( $ ) { // Clear the selection and move focus back to the trigger. e.clearSelection(); - // Handle ClipboardJS focus bug, see https://github.com/zenorocha/clipboard.js/issues/680 - triggerElement.trigger( 'focus' ); // Show success visual feedback. clearTimeout( successTimeout ); diff --git a/src/js/_enqueues/vendor/plupload/handlers.js b/src/js/_enqueues/vendor/plupload/handlers.js index e4ff962c97..b82a6e8847 100644 --- a/src/js/_enqueues/vendor/plupload/handlers.js +++ b/src/js/_enqueues/vendor/plupload/handlers.js @@ -380,8 +380,6 @@ function copyAttachmentUploadURLClipboard() { // Clear the selection and move focus back to the trigger. event.clearSelection(); - // Handle ClipboardJS focus bug, see https://github.com/zenorocha/clipboard.js/issues/680 - triggerElement.trigger( 'focus' ); // Show success visual feedback. clearTimeout( successTimeout ); successElement.removeClass( 'hidden' ); diff --git a/src/js/media/views/attachment/details.js b/src/js/media/views/attachment/details.js index 9e69efeecd..8f450be793 100644 --- a/src/js/media/views/attachment/details.js +++ b/src/js/media/views/attachment/details.js @@ -47,8 +47,6 @@ Details = Attachment.extend(/** @lends wp.media.view.Attachment.Details.prototyp // Clear the selection and move focus back to the trigger. event.clearSelection(); - // Handle ClipboardJS focus bug, see https://github.com/zenorocha/clipboard.js/issues/680 - triggerElement.trigger( 'focus' ); // Show success visual feedback. clearTimeout( successTimeout );