vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-03-31 18:54:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Build/Test Tools: Implement use of the void solution.

Browse Source 
> PHPUnit 8.0.0 introduced a `void` return type declaration to the "fixture" methods – `setUpBeforeClass()`, `setUp()`, `tearDown()` and `tearDownAfterClass()`. As the `void` return type was not introduced until PHP 7.1, this makes it more difficult to create cross-version compatible tests when using fixtures, due to signature mismatches.
>
> The `Yoast\PHPUnitPolyfills\TestCases\TestCase` overcomes the signature mismatch by having two versions. The correct one will be loaded depending on the PHPUnit version being used.
>
> When using this TestCase, if an individual test, or another TestCase which extends this TestCase, needs to overload any of the "fixture" methods, it should do so by using a snake_case variant of the original fixture method name, i.e. `set_up_before_class()`, `set_up()`, `assert_pre_conditions()`, `assert_post_conditions()`, `tear_down()`, and `tear_down_after_class()`.
>
> The snake_case methods will automatically be called by PHPUnit.
>
> > IMPORTANT: The snake_case methods should not call the PHPUnit parent, i.e. do not use `parent::setUp()` from within an overloaded `set_up()` method. If necessary, DO call `parent::set_up()`.

Reference: https://github.com/Yoast/PHPUnit-Polyfills#testcases

This commit renames all declared fixture methods, and calls to parent versions of those fixture methods, from camelCase to snake_case.

Follow-up to [51559-51567].

Props jrf, hellofromTonya, johnbillion, netweb, dd32, pputzer, SergeyBiryukov.
See #46149.

git-svn-id: https://develop.svn.wordpress.org/trunk@51568 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2021-08-07 10:29:41 +00:00
parent cb6bf02638
commit ddb409edca
260 changed files with 726 additions and 726 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/phpunit/includes/abstract-testcase.php
View File

@@ -60,7 +60,7 @@ abstract class WP_UnitTestCase_Base extends PHPUnit_Adapter_TestCase {
/**
* Runs the routine before setting up all tests.
*/
public static function setUpBeforeClass() {
public static function set_up_before_class() {
global $wpdb;
$wpdb->suppress_errors = false;
@@ -68,7 +68,7 @@ abstract class WP_UnitTestCase_Base extends PHPUnit_Adapter_TestCase {
$wpdb->db_connect();
ini_set( 'display_errors', 1 );
parent::setUpBeforeClass();
parent::set_up_before_class();
$class = get_called_class();
@@ -82,8 +82,8 @@ abstract class WP_UnitTestCase_Base extends PHPUnit_Adapter_TestCase {
/**
* Runs the routine after all tests have been run.
*/
public static function tearDownAfterClass() {
parent::tearDownAfterClass();
public static function tear_down_after_class() {
parent::tear_down_after_class();
_delete_all_data();
self::flush_cache();
@@ -100,7 +100,7 @@ abstract class WP_UnitTestCase_Base extends PHPUnit_Adapter_TestCase {
/**
* Runs the routine before each test is executed.
*/
public function setUp() {
public function set_up() {
set_time_limit( 0 );
if ( ! self::$ignore_files ) {
@@ -140,7 +140,7 @@ abstract class WP_UnitTestCase_Base extends PHPUnit_Adapter_TestCase {
/**
* After a test method runs, resets any state in WordPress the test method might have changed.
*/
public function tearDown() {
public function tear_down() {
global $wpdb, $wp_query, $wp;
$wpdb->query( 'ROLLBACK' );
if ( is_multisite() ) {
@@ -535,7 +535,7 @@ abstract class WP_UnitTestCase_Base extends PHPUnit_Adapter_TestCase {
*
* @since 4.2.0
*/
protected function assertPostConditions() {
protected function assert_post_conditions() {
$this->expectedDeprecated();
}