From de06111d6559807c0691fbd819da399341d8b5af Mon Sep 17 00:00:00 2001 From: Jb Audras Date: Mon, 12 Sep 2022 21:50:57 +0000 Subject: [PATCH] Comments: Remove `aria-hidden="true"` attribute for visible text in comment template. This changeset removes `aria-hidden="true"` attribute used for required fields in comments template, for better accessibility. It removes the attribute from both `wp_required_field_indicator()` and `wp_required_field_message()` patterns. Follow-up to [53888]. Props juliemoynat, audrasjb, joedolson, sabernhardt, afercia, costdev. Fixes #55717. git-svn-id: https://develop.svn.wordpress.org/trunk@54136 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/general-template.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wp-includes/general-template.php b/src/wp-includes/general-template.php index 444a2dcddf..acc3b5bda2 100644 --- a/src/wp-includes/general-template.php +++ b/src/wp-includes/general-template.php @@ -5024,7 +5024,7 @@ function __checked_selected_helper( $helper, $current, $echo, $type ) { // phpcs function wp_required_field_indicator() { /* translators: Character to identify required form fields. */ $glyph = __( '*' ); - $indicator = ''; + $indicator = '' . esc_html( $glyph ) . ''; return $indicator; } @@ -5038,7 +5038,7 @@ function wp_required_field_indicator() { */ function wp_required_field_message() { $message = sprintf( - '', + '%s', /* translators: %s: Asterisk symbol (*). */ sprintf( __( 'Required fields are marked %s' ), wp_required_field_indicator() ) );