WPDB: When a db.php drop-in is being used, and it doesn't explicitly define itself as connecting to MySQL, skip the character set checks. This ensures that existing drop-ins won't accidentally run checks that they don't support.

See #21212.


git-svn-id: https://develop.svn.wordpress.org/trunk@30375 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Gary Pendergast
2014-11-18 03:37:23 +00:00
parent 92ae13f0ee
commit de33d35d1f
2 changed files with 37 additions and 7 deletions

View File

@@ -2211,7 +2211,7 @@ class wpdb {
$this->col_meta[ $table ] = $columns;
foreach ( $columns as $column ) {
if ( $column->Collation ) {
if ( ! empty( $column->Collation ) ) {
list( $charset ) = explode( '_', $column->Collation );
$charsets[ strtolower( $charset ) ] = true;
}
@@ -2237,7 +2237,7 @@ class wpdb {
$charset = key( $charsets );
} elseif ( 0 === $count ) {
// No charsets, assume this table can store whatever.
$charset = 'latin1';
$charset = false;
} else {
// More than one charset. Remove latin1 if present and recalculate.
unset( $charsets['latin1'] );
@@ -2291,6 +2291,11 @@ class wpdb {
return $charset;
}
// Skip this entirely if this isn't a MySQL database.
if ( false === $this->is_mysql ) {
return false;
}
if ( empty( $this->table_charset[ $table ] ) ) {
// This primes column information for us.
$table_charset = $this->get_table_charset( $table );
@@ -2378,13 +2383,12 @@ class wpdb {
foreach ( $data as &$value ) {
$charset = $value['charset'];
// latin1 will happily store anything.
if ( 'latin1' === $charset ) {
// Column isn't a string, or is latin1, which will will happily store anything.
if ( false === $charset || 'latin1' === $charset ) {
continue;
}
// Column or value isn't a string.
if ( false === $charset || ! is_string( $value['value'] ) ) {
if ( ! is_string( $value['value'] ) ) {
continue;
}