From df3f14819c56c679fe7270b76b8004f2283d25e2 Mon Sep 17 00:00:00 2001 From: David Baumwald Date: Mon, 10 Jan 2022 16:43:54 +0000 Subject: [PATCH] Build/Test Tools: Re-enable E2E tests for the 5.8 branch. After the 5.9 branch was created, [52449] updated the workflow for testing old branches to include 5.9. However, the E2E tests `-branch` condition was updated to 5.9 instead of adding an additional branch condition for 5.9. This commit re-enables the E2E tests for 5.8. Props desrosj, hellofromTonya. Fixes #54749. git-svn-id: https://develop.svn.wordpress.org/trunk@52546 602fd350-edb4-49c9-b593-d223f7449a82 --- .github/workflows/test-old-branches.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-old-branches.yml b/.github/workflows/test-old-branches.yml index f8f26b2b55..147175197c 100644 --- a/.github/workflows/test-old-branches.yml +++ b/.github/workflows/test-old-branches.yml @@ -45,11 +45,13 @@ jobs: - branch: '5.5' workflow: 'php-compatibility.yml' - # End to End testing was introduced in 5.3 but later removed as there were no meaningful assertions. - # Only the officially supported major branch runs E2E tests so that more assertions can be added, and the - # workflow does not continue to run needlessly on old branches. + # End-to-end testing was introduced in 5.3 but was later removed as there were no meaningful assertions. + # Starting in 5.8 with #52905, some additional tests with real assertions were introduced. + # Branches 5.8 and newer should be tested to confirm no regressions are introduced. - branch: '5.9' workflow: 'end-to-end-tests.yml' + - branch: '5.8' + workflow: 'end-to-end-tests.yml' exclude: # Coding standards and JavaScript testing did not take place in 3.7. - branch: '3.7'