vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-09-24 18:00:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Coding Standards: Restore more descriptive variable names in a few class methods.

Browse Source 
When various methods parameters in child classes were renamed to `$item` to match the parent class for PHP 8 named parameter support, most of the methods restored the more descriptive, specific name at the beginning for better readability, with several exceptions for methods consisting only of a few lines.

To avoid confusion about why some methods do that and some don't, this commit aims to bring more consistency to the code, specifically in list tables' `::column_default()` methods.

Follow-up to [51728], [51737], [51786].

See #58831.

git-svn-id: https://develop.svn.wordpress.org/trunk@56586 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2023-09-14 12:44:23 +00:00
parent 4ba29eb1cb
commit e005108fe1
30 changed files with 95 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/wp-includes/class-walker-category-dropdown.php
+2 -1
View File
@@ -59,7 +59,8 @@ class Walker_CategoryDropdown extends Walker {
public function start_el( &$output, $data_object, $depth = 0, $args = array(), $current_object_id = 0 ) {
// Restores the more descriptive, specific name for use within this method.
$category = $data_object;
$pad = str_repeat( ' ', $depth * 3 );
$pad = str_repeat( ' ', $depth * 3 );
/** This filter is documented in wp-includes/category-template.php */
$cat_name = apply_filters( 'list_cats', $category->name, $category );