vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-03-31 10:44:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Allow metadata to be deleted when meta_value matches 0 or '0'.

Browse Source 
In `delete_metadata()`, be stricter about when to ignore a falsey value of
`$meta_value`.

For backward compatibility, an empty string for `$meta_value` is equivalent to
`null` or `false`.

Props sc0ttkclark.
Fixes #32224.

git-svn-id: https://develop.svn.wordpress.org/trunk@32331 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges
2015-05-01 16:37:35 +00:00
parent 625e7135f3
commit e5e467a41b
2 changed files with 112 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

100
tests/phpunit/tests/meta/deleteMetadata.php Normal file
View File

@@ -0,0 +1,100 @@
<?php
/**
* @group meta
*/
class Tests_Meta_DeleteMetadata extends WP_UnitTestCase {
public function test_all_metas_for_key_should_be_deleted_when_no_meta_value_is_provided() {
$vals = array( '0', '1', '2' );
foreach ( $vals as $val ) {
add_metadata( 'post', 12345, 'foo', $val );
}
$m = get_metadata( 'post', 12345, 'foo', false );
$this->assertEqualSets( $vals, $m );
delete_metadata( 'post', 12345, 'foo' );
$m = get_metadata( 'post', 12345, 'foo', false );
$this->assertEqualSets( array(), $m );
}
public function test_with_meta_value() {
$vals = array( '0', '1', '2' );
foreach ( $vals as $val ) {
add_metadata( 'post', 12345, 'foo', $val );
}
$m = get_metadata( 'post', 12345, 'foo', false );
$this->assertEqualSets( $vals, $m );
delete_metadata( 'post', 12345, 'foo', '1' );
$m = get_metadata( 'post', 12345, 'foo', false );
$expected = array_diff( $vals, array( '1' ) );;
$this->assertEqualSets( $expected, $m );
}
/**
* @ticket 32224
*/
public function test_with_falsey_meta_value_should_not_delete_all_meta() {
$vals = array( '0', '1', '2' );
foreach ( $vals as $val ) {
add_metadata( 'post', 12345, 'foo', $val );
}
$m = get_metadata( 'post', 12345, 'foo', false );
$this->assertEqualSets( $vals, $m );
delete_metadata( 'post', 12345, 'foo', '0' );
$m = get_metadata( 'post', 12345, 'foo', false );
$expected = array_diff( $vals, array( '0' ) );;
$this->assertEqualSets( $expected, $m );
}
/**
* @ticket 32224
*
* This is a backwards compatiblity quirk.
*/
public function test_meta_value_should_be_ignored_when_empty_string() {
$vals = array( '0', '1', '2', '' );
foreach ( $vals as $val ) {
add_metadata( 'post', 12345, 'foo', $val );
}
$m = get_metadata( 'post', 12345, 'foo', false );
$this->assertEqualSets( $vals, $m );
delete_metadata( 'post', 12345, 'foo', '' );
$m = get_metadata( 'post', 12345, 'foo', false );
$this->assertEqualSets( array(), $m );
}
/**
* @ticket 32224
*/
public function test_meta_value_should_be_ignored_when_null() {
$vals = array( '0', '1', '2', '' );
foreach ( $vals as $val ) {
add_metadata( 'post', 12345, 'foo', $val );
}
$m = get_metadata( 'post', 12345, 'foo', false );
$this->assertEqualSets( $vals, $m );
delete_metadata( 'post', 12345, 'foo', null );
$m = get_metadata( 'post', 12345, 'foo', false );
$this->assertEqualSets( array(), $m );
}
/**
* @ticket 32224
*/
public function test_meta_value_should_be_ignored_when_false() {
$vals = array( '0', '1', '2', '' );
foreach ( $vals as $val ) {
add_metadata( 'post', 12345, 'foo', $val );
}
$m = get_metadata( 'post', 12345, 'foo', false );
$this->assertEqualSets( $vals, $m );
delete_metadata( 'post', 12345, 'foo', false );
$m = get_metadata( 'post', 12345, 'foo', false );
$this->assertEqualSets( array(), $m );
}
}