vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 14:20:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bail early when invalid ID is passed to get_comment_class().

Browse Source 
This helps to avoid PHP notices later in the function.

Props walterebert, dipesh.kakadiya, DrewAPicture.
Fixes #33947.

git-svn-id: https://develop.svn.wordpress.org/trunk@34454 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges
2015-09-23 14:08:47 +00:00
parent b23a1fc613
commit e6b7c6b2d4
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/phpunit/tests/comment/getCommentClass.php
View File

@@ -36,4 +36,11 @@ class Tests_Comment_GetCommentClass extends WP_UnitTestCase {
$this->assertContains( 'foo', $classes );
$this->assertContains( 'bar', $classes );
}
/**
* @ticket 33947
*/
public function test_should_return_an_empty_array_for_invalid_comment_id() {
$this->assertSame( array(), get_comment_class( 'foo', 12345 ) );
}
}