vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-04-05 21:24:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unit Tests: one $factory to rule them all, and it shall be static.

Browse Source 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-10-16 21:04:12 +00:00
parent 84272ff8cd
commit e70ebea219
169 changed files with 2631 additions and 2616 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/phpunit/tests/admin/includesComment.php
View File

@@ -6,15 +6,15 @@
*/
class Tests_Admin_IncludesComment extends WP_UnitTestCase {
public function test_must_match_date_and_author() {
$p1 = $this->factory->post->create();
$c1 = $this->factory->comment->create( array(
$p1 = self::$factory->post->create();
$c1 = self::$factory->comment->create( array(
'comment_author' => 1,
'comment_date' => '2014-05-06 12:00:00',
'comment_post_ID' => $p1,
) );
$p2 = $this->factory->post->create();
$c2 = $this->factory->comment->create( array(
$p2 = self::$factory->post->create();
$c2 = self::$factory->comment->create( array(
'comment_author' => 2,
'comment_date' => '2004-01-02 12:00:00',
'comment_post_ID' => $p2,
@@ -28,8 +28,8 @@ class Tests_Admin_IncludesComment extends WP_UnitTestCase {
* @ticket 33871
*/
public function test_default_value_of_timezone_should_be_blog() {
$p = $this->factory->post->create();
$c = $this->factory->comment->create( array(
$p = self::$factory->post->create();
$c = self::$factory->comment->create( array(
'comment_author' => 1,
'comment_post_ID' => $p,
'comment_date' => '2014-05-06 12:00:00',
@@ -43,8 +43,8 @@ class Tests_Admin_IncludesComment extends WP_UnitTestCase {
* @ticket 33871
*/
public function test_should_respect_timezone_blog() {
$p = $this->factory->post->create();
$c = $this->factory->comment->create( array(
$p = self::$factory->post->create();
$c = self::$factory->comment->create( array(
'comment_author' => 1,
'comment_post_ID' => $p,
'comment_date' => '2014-05-06 12:00:00',
@@ -58,8 +58,8 @@ class Tests_Admin_IncludesComment extends WP_UnitTestCase {
* @ticket 33871
*/
public function test_should_respect_timezone_gmt() {
$p = $this->factory->post->create();
$c = $this->factory->comment->create( array(
$p = self::$factory->post->create();
$c = self::$factory->comment->create( array(
'comment_author' => 1,
'comment_post_ID' => $p,
'comment_date' => '2014-05-06 12:00:00',
@@ -73,8 +73,8 @@ class Tests_Admin_IncludesComment extends WP_UnitTestCase {
* @ticket 33871
*/
public function test_invalid_timezone_should_fall_back_on_blog() {
$p = $this->factory->post->create();
$c = $this->factory->comment->create( array(
$p = self::$factory->post->create();
$c = self::$factory->comment->create( array(
'comment_author' => 1,
'comment_post_ID' => $p,
'comment_date' => '2014-05-06 12:00:00',