vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-10-06 23:58:03 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unit Tests: one $factory to rule them all, and it shall be static.

Browse Source 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-10-16 21:04:12 +00:00
parent 84272ff8cd
commit e70ebea219
169 changed files with 2631 additions and 2616 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/ajax/CustomizeMenus.php
+6 -6
View File
@@ -22,7 +22,7 @@ class Tests_Ajax_CustomizeMenus extends WP_Ajax_UnitTestCase {
public function setUp() {
parent::setUp();
require_once ABSPATH . WPINC . '/class-wp-customize-manager.php';
wp_set_current_user( $this->factory->user->create( array( 'role' => 'administrator' ) ) );
wp_set_current_user( self::$factory->user->create( array( 'role' => 'administrator' ) ) );
global $wp_customize;
$this->wp_customize = new WP_Customize_Manager();
$wp_customize = $this->wp_customize;
@@ -65,7 +65,7 @@ class Tests_Ajax_CustomizeMenus extends WP_Ajax_UnitTestCase {
$this->setExpectedException( 'WPAjaxDieStopException' );
}
wp_set_current_user( $this->factory->user->create( array( 'role' => $role ) ) );
wp_set_current_user( self::$factory->user->create( array( 'role' => $role ) ) );
$_POST = array(
'action' => 'load-available-menu-items-customizer',
@@ -307,8 +307,8 @@ class Tests_Ajax_CustomizeMenus extends WP_Ajax_UnitTestCase {
);
// Create some terms and pages.
$this->factory->term->create_many( 5 );
$this->factory->post->create_many( 5, array( 'post_type' => 'page' ) );
self::$factory->term->create_many( 5 );
self::$factory->post->create_many( 5, array( 'post_type' => 'page' ) );
$_POST = array_merge( array(
'action' => 'load-available-menu-items-customizer',
@@ -396,7 +396,7 @@ class Tests_Ajax_CustomizeMenus extends WP_Ajax_UnitTestCase {
$this->setExpectedException( 'WPAjaxDieStopException' );
}
wp_set_current_user( $this->factory->user->create( array( 'role' => $role ) ) );
wp_set_current_user( self::$factory->user->create( array( 'role' => $role ) ) );
$_POST = array(
'action' => 'search-available-menu-items-customizer',
@@ -469,7 +469,7 @@ class Tests_Ajax_CustomizeMenus extends WP_Ajax_UnitTestCase {
*/
function test_ajax_search_available_items_results( $post_args, $expected_results ) {
$this->factory->post->create_many( 5, array( 'post_title' => 'Test Post' ) );
self::$factory->post->create_many( 5, array( 'post_title' => 'Test Post' ) );
$_POST = array_merge( array(
'action' => 'search-available-menu-items-customizer',