vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-04-12 08:34:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unit Tests: one $factory to rule them all, and it shall be static.

Browse Source 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-10-16 21:04:12 +00:00
parent 84272ff8cd
commit e70ebea219
169 changed files with 2631 additions and 2616 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/phpunit/tests/comment/dateQuery.php
View File

@@ -22,7 +22,7 @@ class Tests_Comment_DateQuery extends WP_UnitTestCase {
// Just some dummy posts to use as parents for comments
for ( $i = 1; $i <= 2; $i++ ) {
$this->posts[$i] = $this->factory->post->create();
$this->posts[$i] = self::$factory->post->create();
}
// Be careful modifying this. Tests are coded to expect this exact sample data.
@@ -39,7 +39,7 @@ class Tests_Comment_DateQuery extends WP_UnitTestCase {
);
foreach ( $comment_dates as $comment_date => $comment_parent ) {
$result = $this->factory->comment->create( array(
$result = self::$factory->comment->create( array(
'comment_date' => $comment_date,
'comment_post_ID' => $this->posts[ $comment_parent ],
) );