vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-10-02 21:56:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unit Tests: one $factory to rule them all, and it shall be static.

Browse Source 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-10-16 21:04:12 +00:00
parent 84272ff8cd
commit e70ebea219
169 changed files with 2631 additions and 2616 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/comment/walker.php
+3 -3
View File
@@ -8,15 +8,15 @@ class Tests_Comment_Walker extends WP_UnitTestCase {
function setUp() {
parent::setUp();
$this->post_id = $this->factory->post->create();
$this->post_id = self::$factory->post->create();
}
/**
* @ticket 14041
*/
function test_has_children() {
$comment_parent = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id ) );
$comment_child = $this->factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_parent' => $comment_parent ) );
$comment_parent = self::$factory->comment->create( array( 'comment_post_ID' => $this->post_id ) );
$comment_child = self::$factory->comment->create( array( 'comment_post_ID' => $this->post_id, 'comment_parent' => $comment_parent ) );
$comment_parent = get_comment( $comment_parent );
$comment_child = get_comment( $comment_child );