vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-30 23:30:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unit Tests: one $factory to rule them all, and it shall be static.

Browse Source 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-10-16 21:04:12 +00:00
parent 84272ff8cd
commit e70ebea219
169 changed files with 2631 additions and 2616 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/phpunit/tests/comment/wpCountComments.php
View File

@@ -15,7 +15,7 @@ class Tests_WP_Count_Comments extends WP_UnitTestCase {
}
public function test_wp_count_comments_approved() {
$this->factory->comment->create( array(
self::$factory->comment->create( array(
'comment_approved' => 1
) );
@@ -31,7 +31,7 @@ class Tests_WP_Count_Comments extends WP_UnitTestCase {
}
public function test_wp_count_comments_awaiting() {
$this->factory->comment->create( array(
self::$factory->comment->create( array(
'comment_approved' => 0
) );
@@ -47,7 +47,7 @@ class Tests_WP_Count_Comments extends WP_UnitTestCase {
}
public function test_wp_count_comments_spam() {
$this->factory->comment->create( array(
self::$factory->comment->create( array(
'comment_approved' => 'spam'
) );
@@ -63,7 +63,7 @@ class Tests_WP_Count_Comments extends WP_UnitTestCase {
}
public function test_wp_count_comments_trash() {
$this->factory->comment->create( array(
self::$factory->comment->create( array(
'comment_approved' => 'trash'
) );
@@ -79,7 +79,7 @@ class Tests_WP_Count_Comments extends WP_UnitTestCase {
}
public function test_wp_count_comments_post_trashed() {
$this->factory->comment->create( array(
self::$factory->comment->create( array(
'comment_approved' => 'post-trashed'
) );
@@ -95,10 +95,10 @@ class Tests_WP_Count_Comments extends WP_UnitTestCase {
}
public function test_wp_count_comments_cache() {
$post_id = $this->factory->post->create( array(
$post_id = self::$factory->post->create( array(
'post_status' => 'publish'
) );
$comment_id = $this->factory->comment->create( array(
$comment_id = self::$factory->comment->create( array(
'comment_approved' => '1',
'comment_post_ID' => $post_id
) );