vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-04-14 09:34:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unit Tests: one $factory to rule them all, and it shall be static.

Browse Source 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-10-16 21:04:12 +00:00
parent 84272ff8cd
commit e70ebea219
169 changed files with 2631 additions and 2616 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/phpunit/tests/customize/section.php
View File

@@ -135,7 +135,7 @@ class Tests_WP_Customize_Section extends WP_UnitTestCase {
* @see WP_Customize_Section::check_capabilities()
*/
function test_check_capabilities() {
$user_id = $this->factory->user->create( array( 'role' => 'administrator' ) );
$user_id = self::$factory->user->create( array( 'role' => 'administrator' ) );
wp_set_current_user( $user_id );
$section = new WP_Customize_Section( $this->manager, 'foo' );
@@ -161,7 +161,7 @@ class Tests_WP_Customize_Section extends WP_UnitTestCase {
* @see WP_Customize_Section::maybe_render()
*/
function test_maybe_render() {
wp_set_current_user( $this->factory->user->create( array( 'role' => 'administrator' ) ) );
wp_set_current_user( self::$factory->user->create( array( 'role' => 'administrator' ) ) );
$section = new WP_Customize_Section( $this->manager, 'bar' );
$customize_render_section_count = did_action( 'customize_render_section' );
add_action( 'customize_render_section', array( $this, 'action_customize_render_section_test' ) );
@@ -186,7 +186,7 @@ class Tests_WP_Customize_Section extends WP_UnitTestCase {
* @see WP_Customize_Section::print_template()
*/
function test_print_templates_standard() {
wp_set_current_user( $this->factory->user->create( array( 'role' => 'administrator' ) ) );
wp_set_current_user( self::$factory->user->create( array( 'role' => 'administrator' ) ) );
$section = new WP_Customize_Section( $this->manager, 'baz' );
ob_start();
@@ -201,7 +201,7 @@ class Tests_WP_Customize_Section extends WP_UnitTestCase {
* @see WP_Customize_Section::print_template()
*/
function test_print_templates_custom() {
wp_set_current_user( $this->factory->user->create( array( 'role' => 'administrator' ) ) );
wp_set_current_user( self::$factory->user->create( array( 'role' => 'administrator' ) ) );
$section = new Custom_Section_Test( $this->manager, 'baz' );
ob_start();