vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-07-04 17:20:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unit Tests: one $factory to rule them all, and it shall be static.

Browse Source 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-10-16 21:04:12 +00:00
parent 84272ff8cd
commit e70ebea219
169 changed files with 2631 additions and 2616 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/phpunit/tests/meta.php
View File

@@ -8,7 +8,7 @@ class Tests_Meta extends WP_UnitTestCase {
function setUp() {
parent::setUp();
$this->author = new WP_User( $this->factory->user->create( array( 'role' => 'author' ) ) );
$this->author = new WP_User( self::$factory->user->create( array( 'role' => 'author' ) ) );
$this->meta_id = add_metadata( 'user', $this->author->ID, 'meta_key', 'meta_value' );
$this->delete_meta_id = add_metadata( 'user', $this->author->ID, 'delete_meta_key', 'delete_meta_value' );
}
@@ -194,10 +194,10 @@ class Tests_Meta extends WP_UnitTestCase {
* @ticket 16814
*/
function test_meta_type_cast() {
$post_id1 = $this->factory->post->create();
$post_id1 = self::$factory->post->create();
add_post_meta( $post_id1, 'num_as_longtext', 123 );
add_post_meta( $post_id1, 'num_as_longtext_desc', 10 );
$post_id2 = $this->factory->post->create();
$post_id2 = self::$factory->post->create();
add_post_meta( $post_id2, 'num_as_longtext', 99 );
add_post_meta( $post_id2, 'num_as_longtext_desc', 100 );
@@ -258,7 +258,7 @@ class Tests_Meta extends WP_UnitTestCase {
}
function test_meta_cache_order_asc() {
$post_id = $this->factory->post->create();
$post_id = self::$factory->post->create();
$colors = array( 'red', 'blue', 'yellow', 'green' );
foreach ( $colors as $color )
add_post_meta( $post_id, 'color', $color );