vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 22:30:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unit Tests: one $factory to rule them all, and it shall be static.

Browse Source 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-10-16 21:04:12 +00:00
parent 84272ff8cd
commit e70ebea219
169 changed files with 2631 additions and 2616 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/phpunit/tests/multisite/wpmuValidateUserSignup.php
View File

@@ -63,13 +63,13 @@ class Tests_Multisite_WpmuValidateUserSignup extends WP_UnitTestCase {
}
public function test_should_fail_for_existing_user_name() {
$u = $this->factory->user->create( array( 'user_login' => 'foo123' ) );
$u = self::$factory->user->create( array( 'user_login' => 'foo123' ) );
$v = wpmu_validate_user_signup( 'foo123', 'foo@example.com' );
$this->assertContains( 'user_name', $v['errors']->get_error_codes() );
}
public function test_should_fail_for_existing_user_email() {
$u = $this->factory->user->create( array( 'user_email' => 'foo@example.com' ) );
$u = self::$factory->user->create( array( 'user_email' => 'foo@example.com' ) );
$v = wpmu_validate_user_signup( 'foo123', 'foo@example.com' );
$this->assertContains( 'user_email', $v['errors']->get_error_codes() );
}