vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-04-07 06:05:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unit Tests: one $factory to rule them all, and it shall be static.

Browse Source 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-10-16 21:04:12 +00:00
parent 84272ff8cd
commit e70ebea219
169 changed files with 2631 additions and 2616 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/phpunit/tests/oembed/controller.php
View File

@@ -17,10 +17,10 @@ class Test_oEmbed_Controller extends WP_UnitTestCase {
}
function test_request_json() {
$user = $this->factory->user->create_and_get( array(
$user = self::$factory->user->create_and_get( array(
'display_name' => 'John Doe',
) );
$post = $this->factory->post->create_and_get( array(
$post = self::$factory->post->create_and_get( array(
'post_author' => $user->ID,
'post_title' => 'Hello World',
) );
@@ -60,10 +60,10 @@ class Test_oEmbed_Controller extends WP_UnitTestCase {
}
function test_request_jsonp() {
$user = $this->factory->user->create_and_get( array(
$user = self::$factory->user->create_and_get( array(
'display_name' => 'John Doe',
) );
$post = $this->factory->post->create_and_get( array(
$post = self::$factory->post->create_and_get( array(
'post_author' => $user->ID,
'post_title' => 'Hello World',
) );
@@ -83,10 +83,10 @@ class Test_oEmbed_Controller extends WP_UnitTestCase {
}
function test_request_jsonp_invalid_callback() {
$user = $this->factory->user->create_and_get( array(
$user = self::$factory->user->create_and_get( array(
'display_name' => 'John Doe',
) );
$post = $this->factory->post->create_and_get( array(
$post = self::$factory->post->create_and_get( array(
'post_author' => $user->ID,
'post_title' => 'Hello World',
) );
@@ -118,10 +118,10 @@ class Test_oEmbed_Controller extends WP_UnitTestCase {
}
function test_request_xml() {
$user = $this->factory->user->create_and_get( array(
$user = self::$factory->user->create_and_get( array(
'display_name' => 'John Doe',
) );
$post = $this->factory->post->create_and_get( array(
$post = self::$factory->post->create_and_get( array(
'post_author' => $user->ID,
'post_title' => 'Hello World',
) );
@@ -177,11 +177,11 @@ class Test_oEmbed_Controller extends WP_UnitTestCase {
$this->markTestSkipped( __METHOD__ . ' is a multisite-only test.' );
}
$child = $this->factory->blog->create();
$child = self::$factory->blog->create();
switch_to_blog( $child );
$post = $this->factory->post->create_and_get( array(
$post = self::$factory->post->create_and_get( array(
'post_title' => 'Hello Child Blog',
) );
@@ -207,7 +207,7 @@ class Test_oEmbed_Controller extends WP_UnitTestCase {
$this->assertEquals( home_url() . '/?oembed=true', get_oembed_endpoint_url( '', 'json' ) );
$this->assertEquals( home_url() . '/?oembed=true', get_oembed_endpoint_url( '', 'xml' ) );
$post_id = $this->factory->post->create();
$post_id = self::$factory->post->create();
$url = get_permalink( $post_id );
$url_encoded = urlencode( $url );