vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-05-22 20:24:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unit Tests: one $factory to rule them all, and it shall be static.

Browse Source 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-10-16 21:04:12 +00:00
parent 84272ff8cd
commit e70ebea219
169 changed files with 2631 additions and 2616 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/phpunit/tests/term/cache.php
View File

@@ -15,15 +15,15 @@ class Tests_Term_Cache extends WP_UnitTestCase {
*/
function test_category_children_cache() {
// Test with only one Parent => Child
$term_id1 = $this->factory->category->create();
$term_id1_child = $this->factory->category->create( array( 'parent' => $term_id1 ) );
$term_id1 = self::$factory->category->create();
$term_id1_child = self::$factory->category->create( array( 'parent' => $term_id1 ) );
$hierarchy = _get_term_hierarchy( 'category' );
$this->assertEquals( array( $term_id1 => array( $term_id1_child ) ), $hierarchy );
// Add another Parent => Child
$term_id2 = $this->factory->category->create();
$term_id2_child = $this->factory->category->create( array( 'parent' => $term_id2 ) );
$term_id2 = self::$factory->category->create();
$term_id2_child = self::$factory->category->create( array( 'parent' => $term_id2 ) );
$hierarchy = _get_term_hierarchy( 'category' );
$this->assertEquals( array( $term_id1 => array( $term_id1_child ), $term_id2 => array( $term_id2_child ) ), $hierarchy );
@@ -33,8 +33,8 @@ class Tests_Term_Cache extends WP_UnitTestCase {
* @ticket 22526
*/
function test_category_name_change() {
$term = $this->factory->category->create_and_get( array( 'name' => 'Foo' ) );
$post_id = $this->factory->post->create();
$term = self::$factory->category->create_and_get( array( 'name' => 'Foo' ) );
$post_id = self::$factory->post->create();
wp_set_post_categories( $post_id, $term->term_id );
$post = get_post( $post_id );
@@ -98,7 +98,7 @@ class Tests_Term_Cache extends WP_UnitTestCase {
global $wpdb;
register_taxonomy( 'wptests_tax', 'post' );
$term = $this->factory->term->create( array(
$term = self::$factory->term->create( array(
'taxonomy' => 'wptests_tax',
) );
@@ -124,7 +124,7 @@ class Tests_Term_Cache extends WP_UnitTestCase {
global $wpdb;
register_taxonomy( 'wptests_tax', 'post' );
$term = $this->factory->term->create( array(
$term = self::$factory->term->create( array(
'taxonomy' => 'wptests_tax',
) );
@@ -151,7 +151,7 @@ class Tests_Term_Cache extends WP_UnitTestCase {
global $wpdb;
register_taxonomy( 'wptests_tax', 'post' );
$term = $this->factory->term->create( array(
$term = self::$factory->term->create( array(
'taxonomy' => 'wptests_tax',
) );
@@ -182,7 +182,7 @@ class Tests_Term_Cache extends WP_UnitTestCase {
register_taxonomy( 'wptests_tax', 'post' );
$terms = $this->factory->term->create_many( 5, array(
$terms = self::$factory->term->create_many( 5, array(
'taxonomy' => 'wptests_tax',
) );