vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-07-01 07:40:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unit Tests: one $factory to rule them all, and it shall be static.

Browse Source 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-10-16 21:04:12 +00:00
parent 84272ff8cd
commit e70ebea219
169 changed files with 2631 additions and 2616 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/phpunit/tests/term/getTermField.php
View File

@@ -17,7 +17,7 @@ class Tests_Term_getTermField extends WP_UnitTestCase {
* @ticket 34245
*/
public function test_get_term_field_should_not_return_error_for_empty_taxonomy() {
$term = $this->factory->term->create_and_get( array( 'taxonomy' => $this->taxonomy ) );
$term = self::$factory->term->create_and_get( array( 'taxonomy' => $this->taxonomy ) );
$found = get_term_field( 'taxonomy', $term->term_id, '' );
$this->assertNotWPError( $found );
@@ -28,7 +28,7 @@ class Tests_Term_getTermField extends WP_UnitTestCase {
* @ticket 34245
*/
public function test_get_term_field_supplying_a_taxonomy() {
$term = $this->factory->term->create_and_get( array( 'taxonomy' => $this->taxonomy ) );
$term = self::$factory->term->create_and_get( array( 'taxonomy' => $this->taxonomy ) );
$found = get_term_field( 'taxonomy', $term->term_id, $term->taxonomy );
$this->assertSame( $this->taxonomy, $found );
@@ -38,7 +38,7 @@ class Tests_Term_getTermField extends WP_UnitTestCase {
* @ticket 34245
*/
public function test_get_term_field_supplying_no_taxonomy() {
$term = $this->factory->term->create_and_get( array( 'taxonomy' => $this->taxonomy ) );
$term = self::$factory->term->create_and_get( array( 'taxonomy' => $this->taxonomy ) );
$found = get_term_field( 'taxonomy', $term->term_id );
$this->assertSame( $this->taxonomy, $found );
@@ -48,7 +48,7 @@ class Tests_Term_getTermField extends WP_UnitTestCase {
* @ticket 34245
*/
public function test_get_term_field_should_accept_a_WP_Term_object_or_a_term_id() {
$term = $this->factory->term->create_and_get( array( 'taxonomy' => $this->taxonomy ) );
$term = self::$factory->term->create_and_get( array( 'taxonomy' => $this->taxonomy ) );
$this->assertInstanceOf( 'WP_Term', $term );
$this->assertSame( $term->term_id, get_term_field( 'term_id', $term ) );
@@ -59,7 +59,7 @@ class Tests_Term_getTermField extends WP_UnitTestCase {
* @ticket 34245
*/
public function test_get_term_field_invalid_taxonomy_should_return_WP_Error() {
$term = $this->factory->term->create_and_get( array( 'taxonomy' => $this->taxonomy ) );
$term = self::$factory->term->create_and_get( array( 'taxonomy' => $this->taxonomy ) );
$found = get_term_field( 'taxonomy', $term, 'foo-taxonomy' );
$this->assertWPError( $found );