vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-04-06 13:44:30 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unit Tests: one $factory to rule them all, and it shall be static.

Browse Source 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-10-16 21:04:12 +00:00
parent 84272ff8cd
commit e70ebea219
169 changed files with 2631 additions and 2616 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/phpunit/tests/user/dateQuery.php
View File

@@ -9,10 +9,10 @@ class Tests_User_DateQuery extends WP_UnitTestCase {
* @ticket 27283
*/
public function test_user_registered() {
$u1 = $this->factory->user->create( array(
$u1 = self::$factory->user->create( array(
'user_registered' => '2012-02-14 05:05:05',
) );
$u2 = $this->factory->user->create( array(
$u2 = self::$factory->user->create( array(
'user_registered' => '2013-02-14 05:05:05',
) );
@@ -31,13 +31,13 @@ class Tests_User_DateQuery extends WP_UnitTestCase {
* @ticket 27283
*/
public function test_user_registered_relation_or() {
$u1 = $this->factory->user->create( array(
$u1 = self::$factory->user->create( array(
'user_registered' => '2012-02-14 05:05:05',
) );
$u2 = $this->factory->user->create( array(
$u2 = self::$factory->user->create( array(
'user_registered' => '2013-02-14 05:05:05',
) );
$u3 = $this->factory->user->create( array(
$u3 = self::$factory->user->create( array(
'user_registered' => '2014-02-14 05:05:05',
) );