vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-10-03 22:27:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unit Tests: one $factory to rule them all, and it shall be static.

Browse Source 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-10-16 21:04:12 +00:00
parent 84272ff8cd
commit e70ebea219
169 changed files with 2631 additions and 2616 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/phpunit/tests/user/slashes.php
+3 -3
View File
@@ -8,7 +8,7 @@
class Tests_User_Slashes extends WP_UnitTestCase {
function setUp() {
parent::setUp();
$this->author_id = $this->factory->user->create( array( 'role' => 'administrator' ) );
$this->author_id = self::$factory->user->create( array( 'role' => 'administrator' ) );
$this->old_current_user = get_current_user_id();
wp_set_current_user( $this->author_id );
@@ -83,7 +83,7 @@ class Tests_User_Slashes extends WP_UnitTestCase {
*
*/
function test_edit_user() {
$id = $this->factory->user->create();
$id = self::$factory->user->create();
$_POST = $_GET = $_REQUEST = array();
$_POST['role'] = 'subscriber';
@@ -173,7 +173,7 @@ class Tests_User_Slashes extends WP_UnitTestCase {
*
*/
function test_wp_update_user() {
$id = $this->factory->user->create();
$id = self::$factory->user->create();
$id = wp_update_user(array(
'ID' => $id,
'role' => 'subscriber',