vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-06-28 22:30:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Unit Tests: one $factory to rule them all, and it shall be static.

Browse Source 
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.

Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values. 

#YOLOFriday



git-svn-id: https://develop.svn.wordpress.org/trunk@35225 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Scott Taylor
2015-10-16 21:04:12 +00:00
parent 84272ff8cd
commit e70ebea219
169 changed files with 2631 additions and 2616 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/phpunit/tests/user/updateUserCaches.php
View File

@@ -7,7 +7,7 @@ class Tests_User_UpdateUserCaches extends WP_UnitTestCase {
public function test_should_store_entire_database_row_in_users_bucket() {
global $wpdb;
$u = $this->factory->user->create();
$u = self::$factory->user->create();
$raw_userdata = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM $wpdb->users WHERE ID = %d", $u ) );
update_user_caches( $raw_userdata );
@@ -57,7 +57,7 @@ class Tests_User_UpdateUserCaches extends WP_UnitTestCase {
public function test_should_store_raw_data_in_users_bucket_when_passed_a_wp_user_object() {
global $wpdb;
$u = $this->factory->user->create();
$u = self::$factory->user->create();
$raw_userdata = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM $wpdb->users WHERE ID = %d", $u ) );
$user_object = new WP_User( $u );