vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-07-04 17:20:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Use more appropriate assertions in various tests.

Browse Source 
This replaces instances of `assertSame( [number], count( ... ) )` with `assertCount()` to use native PHPUnit functionality.

Follow-up to [51335], [51337].

See #53363.

git-svn-id: https://develop.svn.wordpress.org/trunk@51367 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Sergey Biryukov
2021-07-07 10:32:56 +00:00
parent b1f0971ee3
commit e77691036d
63 changed files with 291 additions and 291 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/phpunit/tests/user.php
View File

@@ -767,7 +767,7 @@ class Tests_User extends WP_UnitTestCase {
$response = wpmu_validate_user_signup( $user_data['user_login'], $user_data['user_email'] );
$this->assertInstanceOf( 'WP_Error', $response['errors'] );
$this->assertSame( 0, count( $response['errors']->get_error_codes() ) );
$this->assertCount( 0, $response['errors']->get_error_codes() );
}
function _illegal_user_logins_data() {
@@ -1728,10 +1728,10 @@ class Tests_User extends WP_UnitTestCase {
$this->assertTrue( $actual['done'] );
// Number of exported users.
$this->assertSame( 1, count( $actual['data'] ) );
$this->assertCount( 1, $actual['data'] );
// Number of exported user properties.
$this->assertSame( 11, count( $actual['data'][0]['data'] ) );
$this->assertCount( 11, $actual['data'][0]['data'] );
}
/**
@@ -1862,11 +1862,11 @@ class Tests_User extends WP_UnitTestCase {
$this->assertTrue( $actual['done'] );
// Number of exported users.
$this->assertSame( 1, count( $actual['data'] ) );
$this->assertCount( 1, $actual['data'] );
// Number of exported user properties (the 11 core properties,
// plus 1 additional from the filter).
$this->assertSame( 12, count( $actual['data'][0]['data'] ) );
$this->assertCount( 12, $actual['data'][0]['data'] );
// Check that the item added by the filter was retained.
$this->assertSame(
@@ -1894,11 +1894,11 @@ class Tests_User extends WP_UnitTestCase {
$this->assertTrue( $actual['done'] );
// Number of exported users.
$this->assertSame( 1, count( $actual['data'] ) );
$this->assertCount( 1, $actual['data'] );
// Number of exported user properties
// (the 11 core properties, plus 1 additional from the filter).
$this->assertSame( 12, count( $actual['data'][0]['data'] ) );
$this->assertCount( 12, $actual['data'][0]['data'] );
// Check that the duplicate 'name' => 'User ID' was stripped.
$this->assertSame(