From e7cafe6141631bc8125c3173404edab09c868961 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Wed, 22 Jun 2022 14:53:49 +0000 Subject: [PATCH] Code Modernization: Use the integer portion of an item position in `add_submenu_page()`. This fixes an `Implicit conversion from float to int loses precision` PHP 8.1 deprecation notice when adding a new admin menu item with a `float` value passed as the `$position` parameter. This change is covered by existing unit tests and addresses 8 errors when running the test suite on PHP 8.1. References: * [https://php.watch/versions/8.1/deprecate-implicit-conversion-incompatible-float-string PHP 8.1: Implicit incompatible float to int conversion is deprecated] * [https://wiki.php.net/rfc/implicit-float-int-deprecate PHP RFC: Deprecate implicit non-integer-compatible float to int conversions] Follow-up to [52569], [53104]. Props jrf. See #55656, #54798. git-svn-id: https://develop.svn.wordpress.org/trunk@53555 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/includes/plugin.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/wp-admin/includes/plugin.php b/src/wp-admin/includes/plugin.php index 7834abe6f2..3053971e48 100644 --- a/src/wp-admin/includes/plugin.php +++ b/src/wp-admin/includes/plugin.php @@ -1454,6 +1454,7 @@ function add_submenu_page( $parent_slug, $page_title, $menu_title, $capability, // For negative or `0` positions, prepend the submenu. array_unshift( $submenu[ $parent_slug ], $new_sub_menu ); } else { + $position = absint( $position ); // Grab all of the items before the insertion point. $before_items = array_slice( $submenu[ $parent_slug ], 0, $position, true ); // Grab all of the items after the insertion point.