From e7def1dae2124d1a821101eb5af556a887b36535 Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Sun, 18 Sep 2016 14:25:13 +0000 Subject: [PATCH] XML-RPC: Avoid a PHP notice in `::pingback_ping()` if page title was not found. Props RedSand. Fixes #36727. git-svn-id: https://develop.svn.wordpress.org/trunk@38620 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-includes/class-wp-xmlrpc-server.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/wp-includes/class-wp-xmlrpc-server.php b/src/wp-includes/class-wp-xmlrpc-server.php index 3ff4390720..b08347f11c 100644 --- a/src/wp-includes/class-wp-xmlrpc-server.php +++ b/src/wp-includes/class-wp-xmlrpc-server.php @@ -6323,9 +6323,10 @@ class wp_xmlrpc_server extends IXR_Server { $remote_source = preg_replace( "/<\/*(h1|h2|h3|h4|h5|h6|p|th|td|li|dt|dd|pre|caption|input|textarea|button|body)[^>]*>/", "\n\n", $remote_source ); preg_match( '|([^<]*?)|is', $remote_source, $matchtitle ); - $title = $matchtitle[1]; - if ( empty( $title ) ) - return $this->pingback_error( 32, __('We cannot find a title on that page.' ) ); + $title = isset( $matchtitle[1] ) ? $matchtitle[1] : ''; + if ( empty( $title ) ) { + return $this->pingback_error( 32, __( 'We cannot find a title on that page.' ) ); + } $remote_source = strip_tags( $remote_source, '' ); // just keep the tag we need