From e849d6437d1763180876613863aab6848d3b8597 Mon Sep 17 00:00:00 2001
From: Dion Hulse <dd32@git.wordpress.org>
Date: Thu, 7 Apr 2011 09:07:56 +0000
Subject: [PATCH] Move closedir() to better locations to prevent the need for
 error suppression, prevents suppressed Warnings/Notices to be thrown during
 Plugin Installation. Fixes #16547

git-svn-id: https://develop.svn.wordpress.org/trunk@17617 602fd350-edb4-49c9-b593-d223f7449a82
---
 wp-admin/includes/plugin.php | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/wp-admin/includes/plugin.php b/wp-admin/includes/plugin.php
index d10c450b3f..1597b2230d 100644
--- a/wp-admin/includes/plugin.php
+++ b/wp-admin/includes/plugin.php
@@ -243,19 +243,16 @@ function get_plugins($plugin_folder = '') {
 						if ( substr($subfile, -4) == '.php' )
 							$plugin_files[] = "$file/$subfile";
 					}
+					closedir( $plugins_subdir );
 				}
 			} else {
 				if ( substr($file, -4) == '.php' )
 					$plugin_files[] = $file;
 			}
 		}
-	} else {
-		return $wp_plugins;
+		closedir( $plugins_dir );
 	}
 
-	@closedir( $plugins_dir );
-	@closedir( $plugins_subdir );
-
 	if ( empty($plugin_files) )
 		return $wp_plugins;