From eb6ed4faecb7d4805ed2f128c25158f59f32ffad Mon Sep 17 00:00:00 2001 From: Sergey Biryukov Date: Mon, 14 Feb 2022 14:19:10 +0000 Subject: [PATCH] Media: Display an error message in grid view if the attachment could not be deleted. Previously, the attachment was silently removed from the grid but reappeared after a page reload. Follow-up to [22869]. Props kapilpaul, costdev, mukesh27, azouamauriac, SergeyBiryukov. Fixes #55158. git-svn-id: https://develop.svn.wordpress.org/trunk@52725 602fd350-edb4-49c9-b593-d223f7449a82 --- src/js/media/views/attachment/details.js | 8 +++++++- src/wp-includes/media.php | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/js/media/views/attachment/details.js b/src/js/media/views/attachment/details.js index 226a2714d2..9e69efeecd 100644 --- a/src/js/media/views/attachment/details.js +++ b/src/js/media/views/attachment/details.js @@ -154,7 +154,13 @@ Details = Attachment.extend(/** @lends wp.media.view.Attachment.Details.prototyp this.getFocusableElements(); if ( window.confirm( l10n.warnDelete ) ) { - this.model.destroy(); + this.model.destroy( { + wait: true, + error: function() { + window.alert( l10n.errorDeleting ); + } + } ); + this.moveFocus(); } }, diff --git a/src/wp-includes/media.php b/src/wp-includes/media.php index 5d791eb1d0..afbdf332a2 100644 --- a/src/wp-includes/media.php +++ b/src/wp-includes/media.php @@ -4482,6 +4482,7 @@ function wp_enqueue_media( $args = array() ) { 'trashSelected' => __( 'Move to Trash' ), 'restoreSelected' => __( 'Restore from Trash' ), 'deletePermanently' => __( 'Delete permanently' ), + 'errorDeleting' => __( 'Error in deleting the attachment.' ), 'apply' => __( 'Apply' ), 'filterByDate' => __( 'Filter by date' ), 'filterByType' => __( 'Filter by type' ),