vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-07-01 15:50:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Repair the seems_utf8() tests that use Big5 encoding.

Browse Source 
* Provide sample data that is actually encoded in Big5.
* Do some actual assertions against that data.

Props akumria.
Fixes #30455.

git-svn-id: https://develop.svn.wordpress.org/trunk@30525 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges
2014-11-22 20:56:23 +00:00
parent 9b6563f70f
commit ed426ef8ef
2 changed files with 13 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/phpunit/tests/formatting/SeemsUtf8.php
View File

@@ -10,7 +10,7 @@ class Tests_Formatting_SeemsUtf8 extends WP_UnitTestCase {
*
* @dataProvider utf8_strings
*/
function test_returns_true_for_utf8_strings( $utf8_string ) {
function test_returns_true_for_utf8_strings( $utf8_string ) {
// from http://www.i18nguy.com/unicode-example.html
$this->assertTrue( seems_utf8( $utf8_string ) );
}
@@ -28,19 +28,17 @@ class Tests_Formatting_SeemsUtf8 extends WP_UnitTestCase {
* @dataProvider big5_strings
*/
function test_returns_false_for_non_utf8_strings( $big5_string ) {
$this->markTestIncomplete( 'This test does not have any assertions.' );
$big5 = $big5[0];
$strings = array(
"abc",
"123",
$big5
);
$this->assertFalse( seems_utf8( $big5_string ) );
}
function big5_strings() {
// Get data from formatting/big5.txt
return array( array( 'incomplete' ) );
$big5_strings = file( DIR_TESTDATA . '/formatting/big5.txt' );
foreach ( $big5_strings as &$string ) {
$string = (array) trim( $string );
}
unset( $string );
return $big5_strings;
}
}