From ee39026c2db759224d63dd9156738ea1339d69c6 Mon Sep 17 00:00:00 2001 From: Andrew Nacin Date: Tue, 25 Feb 2014 20:06:04 +0000 Subject: [PATCH] Remove unused routing code in revisions. props adamsilverstein. fixes #26565. git-svn-id: https://develop.svn.wordpress.org/trunk@27273 602fd350-edb4-49c9-b593-d223f7449a82 --- src/wp-admin/js/revisions.js | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/src/wp-admin/js/revisions.js b/src/wp-admin/js/revisions.js index a9ddf48f88..48866d6ffc 100644 --- a/src/wp-admin/js/revisions.js +++ b/src/wp-admin/js/revisions.js @@ -1048,15 +1048,12 @@ window.wp = window.wp || {}; } }); - // The revisions router - // takes URLs with #hash fragments and routes them + // The revisions router. + // Maintains the URL routes so browser URL matches state. revisions.Router = Backbone.Router.extend({ initialize: function( options ) { this.model = options.model; - this.routes = _.object([ - [ this.baseUrl( '?from=:from&to=:to' ), 'handleRoute' ], - [ this.baseUrl( '?from=:from&to=:to' ), 'handleRoute' ] - ]); + // Maintain state and history when navigating this.listenTo( this.model, 'update:diff', _.debounce( this.updateUrl, 250 ) ); this.listenTo( this.model, 'change:compareTwoMode', this.updateUrl ); @@ -1085,12 +1082,6 @@ window.wp = window.wp || {}; b = b ? b.id : 0; a = a ? a.id : 0; } - - this.model.set({ - from: this.model.revisions.get( parseInt( a, 10 ) ), - to: this.model.revisions.get( parseInt( a, 10 ) ), - compareTwoMode: compareTwo - }); } });