From ee93e9c94960a7c7b125c030bae61455b1e874e7 Mon Sep 17 00:00:00 2001 From: Andrew Ozz Date: Wed, 22 May 2013 01:30:00 +0000 Subject: [PATCH] Image post format UI: - When initializing wp.Uploader pass null for 'container' and 'browser'. Fixes a bug where another instance of the uploader was attached to . - Destroy the uploader instance if drag/drop is not supported (IE8 & 9). See #24291. git-svn-id: https://develop.svn.wordpress.org/trunk@24310 602fd350-edb4-49c9-b593-d223f7449a82 --- wp-admin/js/post-formats.js | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/wp-admin/js/post-formats.js b/wp-admin/js/post-formats.js index 305637f3c8..8e7ca2c79c 100644 --- a/wp-admin/js/post-formats.js +++ b/wp-admin/js/post-formats.js @@ -67,6 +67,8 @@ window.wp = window.wp || {}; } var uploader = { + container: null, + browser: null, dropzone: $('.wp-format-media-holder[data-format=image]'), success: imageFormatUploadSuccess, error: imageFormatUploadError, @@ -77,9 +79,15 @@ window.wp = window.wp || {}; params: {} }; uploader = new wp.Uploader( uploader ); - uploader.uploader.bind( 'BeforeUpload', imageFormatUploadStart ); - uploader.uploader.bind( 'UploadProgress', imageFormatUploadProgress ); - uploader.uploader.bind( 'FilesAdded', imageFormatUploadFilesAdded ); + + if ( uploader.supports.dragdrop ) { + uploader.uploader.bind( 'BeforeUpload', imageFormatUploadStart ); + uploader.uploader.bind( 'UploadProgress', imageFormatUploadProgress ); + uploader.uploader.bind( 'FilesAdded', imageFormatUploadFilesAdded ); + } else { + uploader.uploader.destroy(); + uploader = null; + } function switchFormatClass( format ) { formatField.val( format );