vhad/wordpress-develop
1
0
Fork 0
mirror of https://github.com/gosticks/wordpress-develop.git synced 2026-05-16 17:24:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Query: Non-scalar and negative values for 'p' should always result in a 404.

Browse Source 
Previously, the 'p' query var was being run through `absint()`, which
caused unexpected results.

Props Akeif, kouratoras.
Fixes #33372.

git-svn-id: https://develop.svn.wordpress.org/trunk@38288 602fd350-edb4-49c9-b593-d223f7449a82
This commit is contained in:
Boone Gorges
2016-08-20 02:31:31 +00:00
parent 54b51f1a26
commit f05beeba8c
2 changed files with 44 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
tests/phpunit/tests/query/parseQuery.php
View File

@@ -51,4 +51,41 @@ class Tests_Query_ParseQuery extends WP_UnitTestCase {
$this->assertSame( true, $q->query_vars['s'] );
}
/**
* @ticket 33372
*/
public function test_parse_query_p_negative_int() {
$q = new WP_Query();
$q->parse_query( array(
'p' => -3,
) );
$this->assertSame( '404', $q->query_vars['error'] );
}
/**
* @ticket 33372
*/
public function test_parse_query_p_array() {
$q = new WP_Query();
$q->parse_query( array(
'p' => array(),
) );
$this->assertSame( '404', $q->query_vars['error'] );
}
/**
* @ticket 33372
*/
public function test_parse_query_p_object() {
$q = new WP_Query();
$q->parse_query( array(
'p' => new stdClass(),
) );
$this->assertSame( '404', $q->query_vars['error'] );
}
}