From f2b56883f099b971ebde6c60f32ef9c66f90e78a Mon Sep 17 00:00:00 2001 From: Jonathan Desrosiers Date: Thu, 25 Feb 2021 14:03:16 +0000 Subject: [PATCH] Build/Test Tools: Disable `fail-fast` for PHPUnit testing. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In GitHub Actions, there is a `fail-fast` option that will cancel all incomplete jobs within a workflow as soon as one failure is encountered. This defaults to `true`. This is great for alerting you of a failure faster, but does not give you the full picture of what is failing. For example, it’s possible that there is a failing test on 2 versions of PHP, but not others. If `fail-fast` is enabled, it’s impossible to know this. Even with `fail-fast` disabled, the workflow will still report a failure if one or more jobs produce a failing result. Props johbillion, jorbin. Fixes #52612. git-svn-id: https://develop.svn.wordpress.org/trunk@50435 602fd350-edb4-49c9-b593-d223f7449a82 --- .github/workflows/phpunit-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/phpunit-tests.yml b/.github/workflows/phpunit-tests.yml index 4d0cbea7c1..3fabb20e2d 100644 --- a/.github/workflows/phpunit-tests.yml +++ b/.github/workflows/phpunit-tests.yml @@ -132,6 +132,7 @@ jobs: needs: setup-wordpress runs-on: ${{ matrix.os }} strategy: + fail-fast: false matrix: php: [ '5.6.20', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0' ] os: [ ubuntu-latest ]